You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by zj...@apache.org on 2015/05/09 02:42:14 UTC

[20/50] hadoop git commit: HADOOP-10356. Corrections in winutils/chmod.c (Contributed by René Nyffenegger)

HADOOP-10356. Corrections in winutils/chmod.c (Contributed by René Nyffenegger)


Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/e42fffc0
Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/e42fffc0
Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/e42fffc0

Branch: refs/heads/YARN-2928
Commit: e42fffc0627956b329c862888ffe78916e8991e3
Parents: 7050542
Author: Arpit Agarwal <ar...@apache.org>
Authored: Fri May 8 11:42:50 2015 -0700
Committer: Zhijie Shen <zj...@apache.org>
Committed: Fri May 8 17:32:49 2015 -0700

----------------------------------------------------------------------
 hadoop-common-project/hadoop-common/CHANGES.txt               | 3 +++
 hadoop-common-project/hadoop-common/src/main/winutils/chmod.c | 6 +++---
 2 files changed, 6 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hadoop/blob/e42fffc0/hadoop-common-project/hadoop-common/CHANGES.txt
----------------------------------------------------------------------
diff --git a/hadoop-common-project/hadoop-common/CHANGES.txt b/hadoop-common-project/hadoop-common/CHANGES.txt
index 432c6b6..ff7531a 100644
--- a/hadoop-common-project/hadoop-common/CHANGES.txt
+++ b/hadoop-common-project/hadoop-common/CHANGES.txt
@@ -632,6 +632,9 @@ Release 2.8.0 - UNRELEASED
     HADOOP-11877. SnappyDecompressor's Logger class name is wrong
     (surendra singh lilhore via vinayakumarb)
 
+    HADOOP-10356. Corrections in winutils/chmod.c. (Rene Nyffenegger via
+    Arpit Agarwal)
+
 Release 2.7.1 - UNRELEASED
 
   INCOMPATIBLE CHANGES

http://git-wip-us.apache.org/repos/asf/hadoop/blob/e42fffc0/hadoop-common-project/hadoop-common/src/main/winutils/chmod.c
----------------------------------------------------------------------
diff --git a/hadoop-common-project/hadoop-common/src/main/winutils/chmod.c b/hadoop-common-project/hadoop-common/src/main/winutils/chmod.c
index c48f734..ff7bff3 100644
--- a/hadoop-common-project/hadoop-common/src/main/winutils/chmod.c
+++ b/hadoop-common-project/hadoop-common/src/main/winutils/chmod.c
@@ -105,7 +105,7 @@ static BOOL ChangeFileModeRecursively(__in LPCWSTR path, __in_opt INT mode,
 //
 int Chmod(__in int argc, __in_ecount(argc) wchar_t *argv[])
 {
-  LPWSTR pathName = NULL;
+  LPCWSTR pathName = NULL;
   LPWSTR longPathName = NULL;
 
   BOOL recursive = FALSE;
@@ -128,7 +128,7 @@ int Chmod(__in int argc, __in_ecount(argc) wchar_t *argv[])
     return EXIT_FAILURE;
   }
 
-  // Convert the path the the long path
+  // Convert the path to the long path
   //
   dwRtnCode = ConvertToLongPath(pathName, &longPathName);
   if (dwRtnCode != ERROR_SUCCESS)
@@ -763,7 +763,7 @@ static BOOL ParseMode(LPCWSTR modeString, PMODE_CHANGE_ACTION *pActions)
     {
       switch (c)
       {
-      case NULL:
+      case L'\0':
         __fallthrough;
       case L',':
         i++;