You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org> on 2016/05/20 17:42:37 UTC

[Impala-CR](cdh5-2.6.0_5.8.0) IMPALA-3574: Handle runtime filters with TupleIsNull predicates

Dimitris Tsirogiannis has uploaded a new patch set (#2).

Change subject: IMPALA-3574: Handle runtime filters with TupleIsNull predicates
......................................................................

IMPALA-3574: Handle runtime filters with TupleIsNull predicates

This commit fixes an issue where an IllegalStateException is thrown
while generating runtime filters if a target expr of a join conjunct
is wrapped in a IF(TupleIsNull, NULL, e) expr. As this is not a valid
expr to be assigned to a scan node (target of a runtime filter), we
unwrap these exprs and replace exprs of the form IF(TupleIsNull, NULL, e)
with 'e' while producing the targer exprs for runtime filters. The original expr
of the join conjunct is not modified.

Change-Id: I2e3e207b4c8522283a1cd0d14be83d42eba58f5a
---
M fe/src/main/java/com/cloudera/impala/analysis/TupleIsNullPredicate.java
M fe/src/main/java/com/cloudera/impala/planner/RuntimeFilterGenerator.java
M testdata/workloads/functional-planner/queries/PlannerTest/runtime-filter-propagation.test
3 files changed, 57 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/47/3147/2
-- 
To view, visit http://gerrit.cloudera.org:8080/3147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2e3e207b4c8522283a1cd0d14be83d42eba58f5a
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>