[PATCH] improved HTMLManagerServlet

[Malcolm Edgar <ma...@hotmail.com>]

Hi all,

Please see the proposed patch for HTMLManagerServlet. This provides an 
improved UI, memory and server reporting information, gc command, supports 
4.1 manager install command and internationalization.

This is almost a rewrite of HTMLManagerServlet, so the diff is not 
particularly informative.

Please see the attached files:
* list.html - example HTML output of list command
* HTMLManagerServlet.java - source code
* LocalStrings.properties - localization strings

Regards Malcolm Edgar



_________________________________________________________________
Join the world�s largest e-mail service with MSN Hotmail. 
http://www.hotmail.com

Re: [PATCH] improved HTMLManagerServlet

[Glenn Nielsen <gl...@voyager.apg.more.net>]

Malcolm Edgar wrote:
> 
> Hi all,
> 
> Please see the proposed patch for HTMLManagerServlet. This provides an
> improved UI, memory and server reporting information, gc command, supports
> 4.1 manager install command and internationalization.
> 

I have a number of comments.  First thanks for working on improving the
HTMLManagerServlet.

1.  GC should not be user initiated, it should be left to the JVM.
    In addition, when virtual hosting web sites, those who have permission
    to manage applications for a particluar host may not be the
    system admin for Tomcat.  I wouldn't want them to be able to trigger a GC.
    The GC option needs to be removed.

2.  The js which you added for onClick really isn't necessary.  The 
    HTMLManagerServlet should be usable w/o JavaScript enabled
    in the browser. It should be removed.

3.  The listing of memory usage isn't really needed if GC is removed.
    It doesn't provide info that is of benefit to someone
    who just manages web applications and is not the Tomcat sysad.
    A Tomcat sysad would be better off using the -verbose:gc arg to
    java when starting Tomcat so that they collect GC data which they
    can later graph to profile the Tomcat JVM memory usage.

These comments are just from a quick review of the code, I haven't
compiled it and tried it out.

> This is almost a rewrite of HTMLManagerServlet, so the diff is not
> particularly informative.
> 
> Please see the attached files:
> * list.html - example HTML output of list command

list.html wasn't attached.

> * HTMLManagerServlet.java - source code
> * LocalStrings.properties - localization strings
> 
> Regards Malcolm Edgar
> 

Regards,

Glenn

----------------------------------------------------------------------
Glenn Nielsen             glenn@more.net | /* Spelin donut madder    |
MOREnet System Programming               |  * if iz ina coment.      |
Missouri Research and Education Network  |  */                       |
----------------------------------------------------------------------

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>