You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "sabi0 (via GitHub)" <gi...@apache.org> on 2023/12/23 21:21:21 UTC
[PR] Add missing spaces in concatenated strings [lucene]
sabi0 opened a new pull request, #12967:
URL: https://github.com/apache/lucene/pull/12967
Mostly changing code like this
`"expected: " + currentFullFlushDelQueue + "but was: "`
to
`"expected: " + currentFullFlushDelQueue + " but was: "`
But also fixing bugs like `"" + i + numDocs` => `"" + (i + numDocs)`.
I took the liberty to also do some minor housekeeping in the affected files:
- corrected grammar and spelling mistakes
- removed unnecessary type parameters
- optimized API usage (e.g. "UTF-8" => `UTF_8`, `assertThat()` => `assertEquals()`, etc.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add missing spaces in concatenated strings [lucene]
Posted by "mikemccand (via GitHub)" <gi...@apache.org>.
mikemccand commented on PR #12967:
URL: https://github.com/apache/lucene/pull/12967#issuecomment-1868407966
I'll backport for 9.10 soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add missing spaces in concatenated strings [lucene]
Posted by "mikemccand (via GitHub)" <gi...@apache.org>.
mikemccand commented on code in PR #12967:
URL: https://github.com/apache/lucene/pull/12967#discussion_r1435749223
##########
lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseDocValuesFormatTestCase.java:
##########
@@ -3631,9 +3631,9 @@ public void testHighOrdsSortedSetDV() throws Exception {
}
private interface FieldCreator {
- public Field next();
+ Field next();
- public DocIdSetIterator iterator(IndexReader r) throws IOException;
Review Comment:
There is another PR about removing the not-needed `public` in interfaces I think.
##########
lucene/core/src/java/org/apache/lucene/index/DocumentsWriter.java:
##########
@@ -236,7 +236,7 @@ synchronized void abort() throws IOException {
}
}
- final boolean flushOneDWPT() throws IOException {
+ boolean flushOneDWPT() throws IOException {
Review Comment:
Ahh because the class itself is already final, great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add missing spaces in concatenated strings [lucene]
Posted by "mikemccand (via GitHub)" <gi...@apache.org>.
mikemccand merged PR #12967:
URL: https://github.com/apache/lucene/pull/12967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add missing spaces in concatenated strings [lucene]
Posted by "mikemccand (via GitHub)" <gi...@apache.org>.
mikemccand commented on PR #12967:
URL: https://github.com/apache/lucene/pull/12967#issuecomment-1871057247
> I started with a "Whitespace may be missing in string concatenation" inspection in IntelliJ IDEA. After applying those fixes I went through the changed files again fixing file-level problems reported by the default inspections profile.
Cool! Thanks for your attention to detail. I wish we could somehow fold these checks into Lucene's static code analysis tooling...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add missing spaces in concatenated strings [lucene]
Posted by "sabi0 (via GitHub)" <gi...@apache.org>.
sabi0 commented on PR #12967:
URL: https://github.com/apache/lucene/pull/12967#issuecomment-1868483440
Thank you for checking this so quickly!
I started with a "Whitespace may be missing in string concatenation" inspection in IntelliJ IDEA.
After applying those fixes I went through the changed files again fixing file-level problems reported by the default inspections profile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add missing spaces in concatenated strings [lucene]
Posted by "sabi0 (via GitHub)" <gi...@apache.org>.
sabi0 commented on PR #12967:
URL: https://github.com/apache/lucene/pull/12967#issuecomment-1871108764
https://www.jetbrains.com/qodana/
Open source projects can get a free license for any JetBrains products:
https://www.jetbrains.com/community/opensource/#support
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org