You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/05/08 16:48:08 UTC

[GitHub] [pulsar] merlimat commented on a change in pull request #4232: [issue 3954] [flink] Use (client/consumer/producer) pojo to pass config to pulsar client

merlimat commented on a change in pull request #4232: [issue 3954] [flink] Use (client/consumer/producer) pojo to pass config to pulsar client
URL: https://github.com/apache/pulsar/pull/4232#discussion_r282153585
 
 

 ##########
 File path: pulsar-flink/src/main/java/org/apache/flink/streaming/connectors/pulsar/FlinkPulsarProducer.java
 ##########
 @@ -85,7 +72,7 @@
     /**
      * {@link Producer} configuration map (will be materialized as a {@link ProducerConfigurationData} instance)
      */
-    protected final Map<String, Object> producerConfig;
+//    protected final Map<String, Object> producerConfig;
 
 Review comment:
   If not needed anymore, just remove it

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services