You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zeroshade (via GitHub)" <gi...@apache.org> on 2026/03/06 23:37:51 UTC
[PR] feat(rust/driver_manager): make some functions and modules pub instead of pub(crate) [arrow-adbc]
zeroshade opened a new pull request, #4052:
URL: https://github.com/apache/arrow-adbc/pull/4052
To facilitate more reuse of the functions for locating drivers, searching for manifests, and loading drivers directly, it makes sense to make some of the functionality directly public instead of being only `pub(crate)`. This will allow consumers to have more reuse of the components in the driver_manager (which I believe was the intent of @felipecrv's refactor in the first place).
This includes `SearchHit`, `process_profile_value`, `DriverLibrary` and some of the searching/loading methods of `DriverLibrary`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(rust/driver_manager): make some functions and modules pub instead of pub(crate) [arrow-adbc]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #4052:
URL: https://github.com/apache/arrow-adbc/pull/4052#discussion_r2936214162
##########
rust/driver_manager/src/search.rs:
##########
@@ -920,7 +920,7 @@ fn get_profile_search_paths(additional_path_list: Option<Vec<PathBuf>>) -> Vec<P
PathBuf::from(conda_prefix)
.join("etc")
.join("adbc")
- .join("drivers"),
+ .join("profiles"),
Review Comment:
yes, this is the `get_profiles_path_list`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(rust/driver_manager): make some functions and modules pub instead of pub(crate) [arrow-adbc]
Posted by "eitsupi (via GitHub)" <gi...@apache.org>.
eitsupi commented on PR #4052:
URL: https://github.com/apache/arrow-adbc/pull/4052#issuecomment-4015600539
The CI failure is unrelated to this change (see #4055).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(rust/driver_manager): make some functions and modules pub instead of pub(crate) [arrow-adbc]
Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on code in PR #4052:
URL: https://github.com/apache/arrow-adbc/pull/4052#discussion_r2908123063
##########
rust/driver_manager/src/search.rs:
##########
@@ -920,7 +920,7 @@ fn get_profile_search_paths(additional_path_list: Option<Vec<PathBuf>>) -> Vec<P
PathBuf::from(conda_prefix)
.join("etc")
.join("adbc")
- .join("drivers"),
+ .join("profiles"),
Review Comment:
intentional change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(rust/driver_manager): make some functions and modules pub instead of pub(crate) [arrow-adbc]
Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on PR #4052:
URL: https://github.com/apache/arrow-adbc/pull/4052#issuecomment-4027131203
> which I believe was the intent of the previous refactor in the first place
Yes. I made then `pub` on my fork :) Didn't want to publish them here too prematurely though. Because once in the open, it's hard to make them private again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(rust/driver_manager): make some functions and modules pub instead of pub(crate) [arrow-adbc]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #4052:
URL: https://github.com/apache/arrow-adbc/pull/4052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org