You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2017/03/18 16:25:15 UTC
[GitHub] zeppelin pull request #2156: [HOTFOX][Branch-0.7] Fix multi dynamic select f...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/2156
[HOTFOX][Branch-0.7] Fix multi dynamic select forms behaviour
### What is this PR for?
This PR is same with #2154 with base branch `branch-0.7`.
Please refer to #2154's description for the details about what the problem is now.
### What type of PR is it?
Bug Fix & Hot Fix
### What is the Jira issue?
N/A
### How should this be tested?
1. Create multiple select forms
```
%md
My first selection is ${my selection1=1,1|2|3}
My second selection is ${my selection2=4,4|5|6}
```
2. Create different types of dynamic form (e.g. 1 select form + 1 checkbox)
```
%md
My selection is ${my selection=1,1|2|3}
My check list is ${checkbox:checkboxTest=list1|list2, list1|list2|list3|list4}
```
There should be `Run on selection change` menu under the paragraph control menu in the above cases. And the select form should appear!
### Screenshots (if appropriate)
- When multiple select forms are created
- When different dynamic forms are created (e.g. 1 checkbox + 1 select form)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin branch-0.7-fix/multiDynamicFormBehaviour
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2156.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2156
----
commit c0641960b0b4878c302a97e8619150f73f80ee8a
Author: RyuAhyoung <ah...@macbook-pro-5.local>
Date: 2017-03-18T16:18:14Z
[branch-0.7] Fix multi dynamicforms behaviour
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2156: [HOTFOX][Branch-0.7] Fix multi dynamic select f...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu closed the pull request at:
https://github.com/apache/zeppelin/pull/2156
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2156: [HOTFOX][Branch-0.7] Fix multi dynamic select forms be...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2156
@Leemoonsoo Thanks! CI has been passed after rebasing from `branch-0.7`.
Will merge into `branch-0.7` as a hotfix if there are no more comments on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2156: [HOTFOX][Branch-0.7] Fix multi dynamic select forms be...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2156
Yes, i think user will expect that same behavior `dropdown` and `checkbox`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2156: [HOTFOX][Branch-0.7] Fix multi dynamic select forms be...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2156
@Leemoonsoo You mean the `checkbox` dynamic form? The `Run on selection change` is only for `select form`.
Do you think this can make user confused?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2156: [HOTFOX][Branch-0.7] Fix multi dynamic select forms be...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2156
@Leemoonsoo Yeah it makes sense. So I updated again as you said.
- When two types of dynamic form in the paragraph
- Only the checkbox is in the paragraph
Could you check again please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2156: [HOTFOX][Branch-0.7] Fix multi dynamic select forms be...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2156
Tested and LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2156: [HOTFOX][Branch-0.7] Fix multi dynamic select forms be...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2156
When "Run on selection change" is checked, check box change does not run paragraph. @AhyoungRyu can you check?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---