[GitHub] spark pull request #18306: [SPARK-21029][SS] All StreamingQuery should be st...

[aray <gi...@git.apache.org>]

Github user aray commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18306#discussion_r143345713
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -562,6 +563,8 @@ class SparkContext(config: SparkConf) extends Logging {
           }
         _cleaner.foreach(_.start())
     
    +    _stopHooks = new SparkShutdownHookManager()
    --- End diff --
    
    @felixcheung I don't get the objection. This is not adding a new shutdown hook, just reusing the class to add "stop hooks" that are called by `sc.stop()`. Furthermore this is needed because `sc.stop()` can not just call `stopAllQueries` unassisted without creating a circular package dependency.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org