[GitHub] spark pull request #15821: [SPARK-13534][WIP][PySpark] Using Apache Arrow to...

[wesm <gi...@git.apache.org>]

Github user wesm commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15821#discussion_r98076494
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
    @@ -17,13 +17,17 @@
     
     package org.apache.spark.sql
     
    -import java.io.CharArrayWriter
    +import java.io.{ByteArrayOutputStream, CharArrayWriter}
    +import java.nio.channels.Channels
     
     import scala.collection.JavaConverters._
     import scala.language.implicitConversions
     import scala.reflect.runtime.universe.TypeTag
     import scala.util.control.NonFatal
     
    +import org.apache.arrow.memory.RootAllocator
    +import org.apache.arrow.vector.file.ArrowWriter
    +import org.apache.arrow.vector.schema.ArrowRecordBatch
    --- End diff --
    
    It may be more palatable to encapsulate these details in a class that is internal to Spark


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org