You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2014/12/10 11:58:15 UTC

[jira] [Updated] (LUCENE-6105) Don't create root arc cache for tiny FSTs

     [ https://issues.apache.org/jira/browse/LUCENE-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless updated LUCENE-6105:
---------------------------------------
    Attachment: LUCENE-6105.patch

Patch.

I fixed FST to only cache if the added RAM required is < 20% of the size of the FST, and if the number of root arcs is >= FIXED_ARRAY_NUM_ARCS_SHALLOW (5), like array'd arcs.

I also simplified how we assert for "caller illegally changed cached root arc", and added a test for that.

> Don't create root arc cache for tiny FSTs
> -----------------------------------------
>
>                 Key: LUCENE-6105
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6105
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/FSTs
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 4.10, Trunk, 5.x
>
>         Attachments: LUCENE-6105.patch
>
>
> The purpose of the root arc cache is to speed up lookups for ASCII terms, but it adds high overhead if the FST is already tiny.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org