[GitHub] [airflow] ashb commented on a change in pull request #11652: Support for sorting DAGs in the web UI

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #11652:
URL: https://github.com/apache/airflow/pull/11652#discussion_r591542423



##########
File path: airflow/www/views.py
##########
@@ -449,6 +490,8 @@ def get_int_arg(value, default=0):
         arg_search_query = request.args.get('search')
         arg_tags_filter = request.args.getlist('tags')
         arg_status_filter = request.args.get('status')
+        arg_sorting_key = request.args.get('sortBy')
+        arg_orderby_key = request.args.get('orderBy')

Review comment:
       K, sortBy and orderBy as argument names is too confusing.
   
   I'd like us to either:
   
   a) change to the single column using `-` (`order_by=col` for asc, `order_by=-col` for descending.); or
   b) change orderBy to `orderDir` (have I got this the right way around?)
   
   a has the advantage that you could then sort by multiple columns (`order_by=col1,-col2`) for instance but I'd be okay not supporting that for now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org