[GitHub] [avro] bellemare commented on pull request #980: ResolvingGrammarGenerator Union use reader instead of writer schema

[GitBox <gi...@apache.org>]

bellemare commented on pull request #980:
URL: https://github.com/apache/avro/pull/980#issuecomment-724270813


   One of the major issues with this PR is that there doesn't appear to be any existing tests that test for it. The reporter issued a comprehensive test (in Kotlin) that _does_ reveal if the patch works (I have verified the code to indeed work), but it seems heavy-handed to implement a single test for what clearly seemed like a mistake in the union coding. 
   
   I am interested to see what a committer says about what we should do with regards to testing this, as it could be symptomatic of underlying issues with the ResolvingGrammarGenerator tests, particularly around nesting and strings. 
   
   Alternatively, I am fine with porting the single-purpose test from Kotlin to Java and submitting that. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org