You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by gu...@apache.org on 2018/03/13 14:31:13 UTC
spark git commit: [MINOR][SQL][TEST] Create table using
`dataSourceName` in `HadoopFsRelationTest`
Repository: spark
Updated Branches:
refs/heads/master 23370554d -> 9ddd1e2ce
[MINOR][SQL][TEST] Create table using `dataSourceName` in `HadoopFsRelationTest`
## What changes were proposed in this pull request?
This PR fixes a minor issue in `HadoopFsRelationTest`, that you should create table using `dataSourceName` instead of `parquet`. The issue won't affect the correctness, but it will generate wrong error message in case the test fails.
## How was this patch tested?
Exsiting tests.
Author: Xingbo Jiang <xi...@databricks.com>
Closes #20780 from jiangxb1987/dataSourceName.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/9ddd1e2c
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/9ddd1e2c
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/9ddd1e2c
Branch: refs/heads/master
Commit: 9ddd1e2ceac8155b30beebb6bbfdcd32296fab2d
Parents: 2337055
Author: Xingbo Jiang <xi...@databricks.com>
Authored: Tue Mar 13 23:31:08 2018 +0900
Committer: hyukjinkwon <gu...@gmail.com>
Committed: Tue Mar 13 23:31:08 2018 +0900
----------------------------------------------------------------------
.../org/apache/spark/sql/sources/HadoopFsRelationTest.scala | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/9ddd1e2c/sql/hive/src/test/scala/org/apache/spark/sql/sources/HadoopFsRelationTest.scala
----------------------------------------------------------------------
diff --git a/sql/hive/src/test/scala/org/apache/spark/sql/sources/HadoopFsRelationTest.scala b/sql/hive/src/test/scala/org/apache/spark/sql/sources/HadoopFsRelationTest.scala
index 80aff44..5339799 100644
--- a/sql/hive/src/test/scala/org/apache/spark/sql/sources/HadoopFsRelationTest.scala
+++ b/sql/hive/src/test/scala/org/apache/spark/sql/sources/HadoopFsRelationTest.scala
@@ -335,16 +335,17 @@ abstract class HadoopFsRelationTest extends QueryTest with SQLTestUtils with Tes
test("saveAsTable()/load() - non-partitioned table - ErrorIfExists") {
withTable("t") {
- sql("CREATE TABLE t(i INT) USING parquet")
- intercept[AnalysisException] {
+ sql(s"CREATE TABLE t(i INT) USING $dataSourceName")
+ val msg = intercept[AnalysisException] {
testDF.write.format(dataSourceName).mode(SaveMode.ErrorIfExists).saveAsTable("t")
- }
+ }.getMessage
+ assert(msg.contains("Table `t` already exists"))
}
}
test("saveAsTable()/load() - non-partitioned table - Ignore") {
withTable("t") {
- sql("CREATE TABLE t(i INT) USING parquet")
+ sql(s"CREATE TABLE t(i INT) USING $dataSourceName")
testDF.write.format(dataSourceName).mode(SaveMode.Ignore).saveAsTable("t")
assert(spark.table("t").collect().isEmpty)
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org