You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pluto-dev@portals.apache.org by "Craig Doremus (JIRA)" <ji...@apache.org> on 2007/05/19 17:58:16 UTC
[jira] Created: (PLUTO-367) Create a testsuite test for JSR-286
shared render parameters.
Create a testsuite test for JSR-286 shared render parameters.
-------------------------------------------------------------
Key: PLUTO-367
URL: https://issues.apache.org/jira/browse/PLUTO-367
Project: Pluto
Issue Type: Test
Components: portlets-testsuite
Affects Versions: 1.1-286-COMPATIBILITY
Environment: All
Reporter: Craig Doremus
Fix For: 1.1-286-COMPATIBILITY
A testsuite test needs to be created to test JSR-286 shared render parameters. This is necessary to make sure merging the 1.1-286-COMPATIBILITY branch with the Pluto trunk and any other 1.1-286-COMPATIBILITY branch refactorings does not break this functionality.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PLUTO-367) Add public render parameters tests to
testsuite for JSR-286
Posted by "Craig Doremus (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Craig Doremus updated PLUTO-367:
--------------------------------
Fix Version/s: 1.1-286-trunk-merge
Affects Version/s: 1.1-286-trunk-merge
Summary: Add public render parameters tests to testsuite for JSR-286 (was: Create a testsuite test for JSR-286 shared render parameters.)
Modified title to make it more visible in PLUTO-442 link
> Add public render parameters tests to testsuite for JSR-286
> -----------------------------------------------------------
>
> Key: PLUTO-367
> URL: https://issues.apache.org/jira/browse/PLUTO-367
> Project: Pluto
> Issue Type: Test
> Components: portlets-testsuite
> Affects Versions: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
> Environment: All
> Reporter: Craig Doremus
> Fix For: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
>
>
> A testsuite test needs to be created to test JSR-286 shared render parameters. This is necessary to make sure merging the 1.1-286-COMPATIBILITY branch with the Pluto trunk and any other 1.1-286-COMPATIBILITY branch refactorings does not break this functionality.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PLUTO-367) Add public render parameters tests to
testsuite for JSR-286
Posted by "Craig Doremus (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554129 ]
Craig Doremus commented on PLUTO-367:
-------------------------------------
I discovered that when more than one public render parameter is used by a portlet, they all are given null values. This is reported in PLUTO-454. The PLUTO-454 issue should be addressed before the one I previously reported in this issue is addressed.
For the record, calls to PortalURLParameter.getWindow() are done without null checks in the following methods:
PortalURLImpl.addParameter()
PortalURLImpl.clearParameters()
PortalURLParserImpl.toString() 3 occurrances
RelativePortalURLImpl.addParameter()
RelativePortalURLImpl.clearParameters()
> Add public render parameters tests to testsuite for JSR-286
> -----------------------------------------------------------
>
> Key: PLUTO-367
> URL: https://issues.apache.org/jira/browse/PLUTO-367
> Project: Pluto
> Issue Type: Test
> Components: portlets-testsuite
> Affects Versions: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
> Environment: All
> Reporter: Craig Doremus
> Fix For: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
>
>
> A testsuite test needs to be created to test JSR-286 shared render parameters. This is necessary to make sure merging the 1.1-286-COMPATIBILITY branch with the Pluto trunk and any other 1.1-286-COMPATIBILITY branch refactorings does not break this functionality.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (PLUTO-367) Add public render parameters tests to
testsuite for JSR-286
Posted by "Ate Douma (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ate Douma resolved PLUTO-367.
-----------------------------
Resolution: Fixed
Implemented
> Add public render parameters tests to testsuite for JSR-286
> -----------------------------------------------------------
>
> Key: PLUTO-367
> URL: https://issues.apache.org/jira/browse/PLUTO-367
> Project: Pluto
> Issue Type: Test
> Components: portlets-testsuite
> Affects Versions: 1.1-286-COMPATIBILITY, 2.0.0
> Environment: All
> Reporter: Craig Doremus
> Fix For: 1.1-286-COMPATIBILITY, 2.0.0
>
>
> A testsuite test needs to be created to test JSR-286 shared render parameters. This is necessary to make sure merging the 1.1-286-COMPATIBILITY branch with the Pluto trunk and any other 1.1-286-COMPATIBILITY branch refactorings does not break this functionality.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PLUTO-367) Add public render parameters tests to
testsuite for JSR-286
Posted by "Torsten Dettborn (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553720 ]
Torsten Dettborn commented on PLUTO-367:
----------------------------------------
Hi Craig,
the PublicRenderParameter isn't bound to a window, so it's right to add the null checks. Thanks for adding the testportlets for the testsuite.
> Add public render parameters tests to testsuite for JSR-286
> -----------------------------------------------------------
>
> Key: PLUTO-367
> URL: https://issues.apache.org/jira/browse/PLUTO-367
> Project: Pluto
> Issue Type: Test
> Components: portlets-testsuite
> Affects Versions: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
> Environment: All
> Reporter: Craig Doremus
> Fix For: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
>
>
> A testsuite test needs to be created to test JSR-286 shared render parameters. This is necessary to make sure merging the 1.1-286-COMPATIBILITY branch with the Pluto trunk and any other 1.1-286-COMPATIBILITY branch refactorings does not break this functionality.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PLUTO-367) Add public render parameters tests to
testsuite for JSR-286
Posted by "Craig Doremus (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556480#action_12556480 ]
Craig Doremus commented on PLUTO-367:
-------------------------------------
Added checkPublicRenderParameter test to testsuite in SVN rev. 609511. This is the first test in a suite of public render parameter tests that need to be developed.
> Add public render parameters tests to testsuite for JSR-286
> -----------------------------------------------------------
>
> Key: PLUTO-367
> URL: https://issues.apache.org/jira/browse/PLUTO-367
> Project: Pluto
> Issue Type: Test
> Components: portlets-testsuite
> Affects Versions: 2.0.0, 1.1-286-COMPATIBILITY
> Environment: All
> Reporter: Craig Doremus
> Fix For: 2.0.0, 1.1-286-COMPATIBILITY
>
>
> A testsuite test needs to be created to test JSR-286 shared render parameters. This is necessary to make sure merging the 1.1-286-COMPATIBILITY branch with the Pluto trunk and any other 1.1-286-COMPATIBILITY branch refactorings does not break this functionality.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PLUTO-367) Add public render parameters tests to
testsuite for JSR-286
Posted by "Craig Doremus (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PLUTO-367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12553718 ]
Craig Doremus commented on PLUTO-367:
-------------------------------------
In working on these Public Render Parameter tests, I found that line 167 in RelativePortalURLImpl (clearParameters() method) threw a NullPointerException because the window ID was null for public render parameters (the PortalURLParameter.getWindow() call returns null). I stuck a null check there and it worked.
However I noticed a number of other places where PortalURLParameter.getWindow() id was called and some of them did not have a null check. I can also stick null checks where they are missing, but I want to make sure this does not have unintended consequences. Torsten (or anyone else), can you comment on this?
BTW, my tests indicate that if a public render parameters is not declared by a supported-public-render-parameter element in a portlet.xml record of a portlet instance, then the portlet window does not see it. This is proper behaviour according to the JSR-286 spec. I will add that check and others to this testsuite test.
> Add public render parameters tests to testsuite for JSR-286
> -----------------------------------------------------------
>
> Key: PLUTO-367
> URL: https://issues.apache.org/jira/browse/PLUTO-367
> Project: Pluto
> Issue Type: Test
> Components: portlets-testsuite
> Affects Versions: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
> Environment: All
> Reporter: Craig Doremus
> Fix For: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
>
>
> A testsuite test needs to be created to test JSR-286 shared render parameters. This is necessary to make sure merging the 1.1-286-COMPATIBILITY branch with the Pluto trunk and any other 1.1-286-COMPATIBILITY branch refactorings does not break this functionality.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.