You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Vyacheslav Koptilin (Jira)" <ji...@apache.org> on 2022/08/08 13:32:00 UTC
[jira] [Resolved] (IGNITE-17454) Logger need to highlight somehow about wrong formatting template.
[ https://issues.apache.org/jira/browse/IGNITE-17454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vyacheslav Koptilin resolved IGNITE-17454.
------------------------------------------
Resolution: Won't Fix
It seems to me, the proposed check should be done in all cases, even though a logging level is not active (otherwise we may mistakenly skip a wrong string template). In this case, this check will always have a penalty. So, I would propose to close this ticket.
> Logger need to highlight somehow about wrong formatting template.
> -----------------------------------------------------------------
>
> Key: IGNITE-17454
> URL: https://issues.apache.org/jira/browse/IGNITE-17454
> Project: Ignite
> Issue Type: Improvement
> Affects Versions: 3.0.0-alpha5
> Reporter: Evgeny Stanilovsky
> Assignee: Vladislav Pyatkov
> Priority: Major
> Labels: ignite-3
>
> Seems it`s easy to implement without any performance impact about wrong formatting (possible human factor) in logging.
> Check:
> *LOG.info("test [{]", 4);* -> outputs : *INFO: test [{]*
> *LOG.info("test [{} {]", 4, 5);* -> outputs : *INFO: test [4 {]*
> Warn or possibly exception is useless to raise in such a case.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)