You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@esme.apache.org by es...@apache.org on 2010/01/03 17:11:54 UTC

svn commit: r895437 - in /incubator/esme/trunk/server/src: main/scala/org/apache/esme/actor/UserActor.scala test/scala/org/apache/esme/api/API2Test.scala

Author: esjewett
Date: Sun Jan  3 16:11:54 2010
New Revision: 895437

URL: http://svn.apache.org/viewvc?rev=895437&view=rev
Log:
[ESME-151] POST /api2/user/messages?message=something&pool=poolname&tags=#one,#two drops the tags (when posting to pool)

Modified:
    incubator/esme/trunk/server/src/main/scala/org/apache/esme/actor/UserActor.scala
    incubator/esme/trunk/server/src/test/scala/org/apache/esme/api/API2Test.scala

Modified: incubator/esme/trunk/server/src/main/scala/org/apache/esme/actor/UserActor.scala
URL: http://svn.apache.org/viewvc/incubator/esme/trunk/server/src/main/scala/org/apache/esme/actor/UserActor.scala?rev=895437&r1=895436&r2=895437&view=diff
==============================================================================
--- incubator/esme/trunk/server/src/main/scala/org/apache/esme/actor/UserActor.scala (original)
+++ incubator/esme/trunk/server/src/main/scala/org/apache/esme/actor/UserActor.scala Sun Jan  3 16:11:54 2010
@@ -117,10 +117,15 @@
         f()
         
       case CreateMessage(text, tags, when, metaData, source, replyTo, pool) =>
-        val tagLst = pool match {
-          case Empty => tags.removeDuplicates.map(Tag.findOrCreate)
-          case _ => Nil
-        }
+        val tagLst = tags.removeDuplicates.map(Tag.findOrCreate)
+
+/* Removed to fix [ESME-151] - may have security implications?
+ *
+ *        val tagLst = pool match {
+ *         case Empty => tags.removeDuplicates.map(Tag.findOrCreate)
+ *         case _ => Nil
+ *       }
+ */
 
         Message.create.author(userId).when(when).
         source(source).

Modified: incubator/esme/trunk/server/src/test/scala/org/apache/esme/api/API2Test.scala
URL: http://svn.apache.org/viewvc/incubator/esme/trunk/server/src/test/scala/org/apache/esme/api/API2Test.scala?rev=895437&r1=895436&r2=895437&view=diff
==============================================================================
--- incubator/esme/trunk/server/src/test/scala/org/apache/esme/api/API2Test.scala (original)
+++ incubator/esme/trunk/server/src/test/scala/org/apache/esme/api/API2Test.scala Sun Jan  3 16:11:54 2010
@@ -354,7 +354,7 @@
           mess_res <- session.post("user/messages",
             "message" -> "test POST message",
             "tags" -> "test,tag",
-            "pool" -> 1)
+            "pool" -> "test_pool1")
           all_msgs <- session.get("user/messages?timeout=2")
         } {          
           println(all_msgs.xml)