[jira] [Commented] (POOL-225) Changes to findbugs-exclude-filter.xml to eliminate false alerts on Evictor classes

["Sebb (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/POOL-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425321#comment-13425321 ] 

Sebb commented on POOL-225:
---------------------------

SOrry, but there's a problem with the patch - it contains a lot of spurious changes, making it difficult to see what is actually different.

Also, it's difficult to read patches that are compressed. Please provide patches as plain text.
                
> Changes to findbugs-exclude-filter.xml to eliminate false alerts on Evictor classes
> -----------------------------------------------------------------------------------
>
>                 Key: POOL-225
>                 URL: https://issues.apache.org/jira/browse/POOL-225
>             Project: Commons Pool
>          Issue Type: Improvement
>    Affects Versions: 1.6
>            Reporter: Liviu Tudor
>            Priority: Trivial
>              Labels: findbugs
>             Fix For: 1.6.1
>
>         Attachments: POOL-225.patch.bz2
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> For both {{GenericKeyedObjectPool}} and {{GenericObjectPool}}, FindBugs signals an inconsistent sycnhronization warning ({{IS2_INCONSISTENT_SYNC}}) however it turns out it's a false alert.
> Talking to [pool] developers, the general consensus was to update {{findbugs-exclude-filter.xml}} to exclude these 2 checks, hence this ticket.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira