You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucenenet.apache.org by ni...@apache.org on 2020/04/10 08:45:17 UTC

[lucenenet] branch master updated: CONTRIBUTING.md + README.md: Removed info about ICLA. Per legal, we only need to have this signed when a contributor becomes a committer, there is no reason to discuss this for PRs. See: https://lists.apache.org/thread.html/re60f365f1236aee3417b23e13efe4286a47968aaec2c12842e45ff6b%40%3Cdev.lucenenet.apache.org%3E

This is an automated email from the ASF dual-hosted git repository.

nightowl888 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/lucenenet.git


The following commit(s) were added to refs/heads/master by this push:
     new 4285e3d  CONTRIBUTING.md + README.md: Removed info about ICLA. Per legal, we only need to have this signed when a contributor becomes a committer, there is no reason to discuss this for PRs. See: https://lists.apache.org/thread.html/re60f365f1236aee3417b23e13efe4286a47968aaec2c12842e45ff6b%40%3Cdev.lucenenet.apache.org%3E
4285e3d is described below

commit 4285e3dc10c3455f7738a419c527679ce56c2fb3
Author: Shad Storhaug <sh...@shadstorhaug.com>
AuthorDate: Fri Apr 10 15:29:10 2020 +0700

    CONTRIBUTING.md + README.md: Removed info about ICLA. Per legal, we only need to have this signed when a contributor becomes a committer, there is no reason to discuss this for PRs. See: https://lists.apache.org/thread.html/re60f365f1236aee3417b23e13efe4286a47968aaec2c12842e45ff6b%40%3Cdev.lucenenet.apache.org%3E
---
 CONTRIBUTING.md | 9 ++++-----
 README.md       | 8 +++-----
 2 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 61e6b1d..01a970a 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -12,8 +12,7 @@ You have found a bug or you have an idea for a cool new enhancement? Contributin
   - If reporting a bug, clearly describe the issue including steps to reproduce, observed behavior, and expected behavior.
   - If reporting a bug, provide source code that we can run without any alteration demonstrating the issue. Issues submitted with runnable code will be given a higher priority than those submitted without.
 - If you will be submitting a pull request, fork the repository on GitHub.
-  - If this is the first time you are contributing, submit an [Individual Contributor License Agreement](https://cwiki.apache.org/confluence/display/LUCENENET/Individual+Contributor+License).
-  - Create a new descriptive branch (tracking master) and [submit a Pull Request](https://help.github.com/articles/creating-a-pull-request/) once it is ready to be reviewed and merged.
+  - Create a new branch with a descriptive name (tracking master) and [submit a Pull Request](https://help.github.com/articles/creating-a-pull-request/).
   
 ## Up For Grabs
 
@@ -21,15 +20,15 @@ There are several [**Open Issues on JIRA**](https://issues.apache.org/jira/proje
 
 ## Other Ways To Help
 
+* Be a power beta tester. Make it your mission to track down bugs and report them to us on [JIRA](https://issues.apache.org/jira/issues/?jql=project%20%3D%20LUCENENET%20AND%20status%20%3D%20Open).
+* Optimizing code. During porting we have ended up with some code that is less than optimal. We could use a hand getting everything up to speed (pun intended).
+* Helping update the API, or at least just providing feedback on which API changes are affecting usability. There are several things on our radar, like integrating something like [Lucene.Net.Linq](https://github.com/themotleyfool/Lucene.Net.Linq) directly into our project, [converting the remaining public-facing iterator classes into `IEnumerator<T>`](https://issues.apache.org/jira/projects/LUCENENET/issues/LUCENENET-469?filter=allopenissues) so they can be used with foreach loops, addin [...]
 * Making demos and tutorials, blogging about Lucene.Net, etc. (and providing feedback on how we can make the API better!). If you write a helpful Lucene.Net post on your blog, be sure to let us know so we can link to it.
 * Helping out with documentation. We are still trying to make the API docs easily navigable (see #206), and there are many files that are not formatted correctly (links not appearing, tables not very readable, etc). Also, we need help getting all of the Java-related documentation converted to use .NET methodologies.
 * Fixing TODOs. There are several TODOs throughout the code that need to be reviewed and action taken, if necessary. Search for `LUCENENET TODO|LUCENE TO-DO` using the regular expression option in Visual Studio to find them. Do note there are a lot of TODOs left over from Java Lucene that are safe to ignore.
 * Reviewing code. Pick a random section, review line by line, comparing the code against the [original Lucene 4.8.0 code](https://github.com/apache/lucene-solr/tree/releases/lucene-solr/4.8.0/lucene). Many of the bugs have been found this way, as the tests are not showing them. Let us know if you find anything suspicious on the [dev mailing list](https://cwiki.apache.org/confluence/display/LUCENENET/Mailing+Lists) or submit a pull request.
-* Optimizing code. During porting we have ended up with some code that is less than optimal. We could use a hand getting everything up to speed (pun intended).
-* Helping update the API, or at least just providing feedback on what is important. There are several things on our radar, like integrating something like [Lucene.Net.Linq](https://github.com/themotleyfool/Lucene.Net.Linq) directly into our project, [converting the remaining public-facing iterator classes into `IEnumerator<T>`](https://issues.apache.org/jira/projects/LUCENENET/issues/LUCENENET-469?filter=allopenissues) so they can be used with foreach loops, adding extension methods to r [...]
 * Creating projects to make Lucene.Net easier to use with various .NET frameworks (ASP.NET MVC, WebApi, AspNetCore, WPF, EntityFramework, etc). In general, we would like common tasks as easy as possible to integrate into applications build on these frameworks without everyone having to write the same boilerplate code.
 * Building automation tools to eliminate some of the manual work of managing the project, updating information on various web pages, creating tools to make porting/upgrading more automated, etc.
-* Be a power beta tester. Make it your mission to track down bugs and report them to us on [JIRA](https://issues.apache.org/jira/issues/?jql=project%20%3D%20LUCENENET%20AND%20status%20%3D%20Open).
 
 Or, if none of that interests you, join our [dev mailing list](https://cwiki.apache.org/confluence/display/LUCENENET/Mailing+Lists) and ask!
 
diff --git a/README.md b/README.md
index d9be2e2..ea2436f 100644
--- a/README.md
+++ b/README.md
@@ -138,7 +138,7 @@ If you have a general how-to question or need help from the Lucene.Net community
 
 [user@lucenenet.apache.org](mailto:user@lucenenet.apache.org)
 
-We recommend you join the [user mailing list](https://cwiki.apache.org/confluence/display/LUCENENET/Mailing+Lists) to stay looped into all user discussions.
+Note that you need to join the [user mailing list](https://cwiki.apache.org/confluence/display/LUCENENET/Mailing+Lists) to see replies.
 
 Alternatively, you can get help via [StackOverflow](https://stackoverflow.com/questions/tagged/lucene.net).
 
@@ -154,14 +154,12 @@ To start a development discussion regarding technical features of Lucene.Net, pl
 
 [dev@lucenenet.apache.org](mailto:dev@lucenenet.apache.org)
 
-We recommend you join both the [user and dev mailing lists](https://cwiki.apache.org/confluence/display/LUCENENET/Mailing+Lists) to stay looped in to all user and developer discussions.
+Note that you need to join the [dev mailing lists](https://cwiki.apache.org/confluence/display/LUCENENET/Mailing+Lists) to see replies.
 
 ### Submit a Pull Request
 
 Before you start working on a pull request, please read our [Contributing](https://github.com/apache/lucenenet/blob/master/CONTRIBUTING.md) guide.
 
-If you plan to submit multiple pull requests, please submit an [Individual Contributor License](https://cwiki.apache.org/confluence/display/LUCENENET/Individual+Contributor+License), or for individual pull requests, just submit the request and in the description state that the code is your original work and you license it under the [Apache License v2](http://www.apache.org/licenses/LICENSE-2.0).
-
 ## Building and Testing
 
 ### Command Line
@@ -273,7 +271,7 @@ We have setup our `azure-pipelines.yml` file with logical defaults so anyone wit
    - Click the "Create Pipeline" or "New Pipeline" button, depending on whether any pipelines already exist.
    - Select GitHub as the location to find the YAML file.
    - Select the fork of this repository you created in "Prerequisites". Note that if this is a new Azure DevOps account you may need to [setup extra permissions to access your GitHub account](https://docs.microsoft.com/en-us/azure/devops/pipelines/repos/github?view=azure-devops&tabs=yaml).
-   - Next a "Review your YAML" page is presented showing the contents of `azure-pipelines.yml`. There is documentation near the top of the file indicating the varaibles that can be setup to enable additional options, but note that the default configuration will automatically run the build and all of the tests.
+   - Next a "Review your YAML" page is presented showing the contents of `azure-pipelines.yml`. There is documentation near the top of the file indicating the variables that can be setup to enable additional options, but note that the default configuration will automatically run the build and all of the tests.
    - Click the "Run" button at the top right of the page.
 
 ##### If you already have a pipeline set up: