You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openaz.apache.org by Okke Harsta <oh...@zilverline.com> on 2015/12/03 10:28:54 UTC
Pull request
Hi,
Our Policy Enforcement Point persists any XACML Result that returns either Deny or Indeterminate with a reference to the PolicyIdentifier(s). The current Policy and PolicySet implementations do not include the PolicyIdentifiers in case the Decision is not Permit or Deny despite the Request returning true for Request#getReturnPolicyIdList.
I made a pull request - https://github.com/apache/incubator-openaz/pull/1 <https://github.com/apache/incubator-openaz/pull/1> - to remedy this and added unit tests to verify the new behaviour. Normally I would create an issue with a reference to the pull request (and vice versa) but I could not create an issue in https://github.com/apache/incubator-openaz <https://github.com/apache/incubator-openaz>.
Could anybody have a look at the pull request and comment on it?
Thanks,
Okke
Re: Pull request
Posted by "DRAGOSH, PAMELA L (PAM)" <pd...@research.att.com>.
Okke and David,
My apologies, I will look at this tomorrow.
Thanks for your help and patience,
Pam
On 12/16/15, 11:54 AM, "David Ash" <gr...@gmail.com> wrote:
>Looks good to me, although I'm no expert. I know Pam is either on or
>between vacations, and is really the person to comment on this matter.
>
>
>Thanks!
>David
>
>On Thu, Dec 3, 2015 at 2:28 AM, Okke Harsta <oh...@zilverline.com>
>wrote:
>
>> Hi,
>>
>> Our Policy Enforcement Point persists any XACML Result that returns
>>either
>> Deny or Indeterminate with a reference to the PolicyIdentifier(s). The
>> current Policy and PolicySet implementations do not include the
>> PolicyIdentifiers in case the Decision is not Permit or Deny despite the
>> Request returning true for Request#getReturnPolicyIdList.
>>
>> I made a pull request -
>>https://github.com/apache/incubator-openaz/pull/1
>> <https://github.com/apache/incubator-openaz/pull/1> - to remedy this and
>> added unit tests to verify the new behaviour. Normally I would create an
>> issue with a reference to the pull request (and vice versa) but I could
>>not
>> create an issue in https://github.com/apache/incubator-openaz <
>> https://github.com/apache/incubator-openaz>.
>>
>> Could anybody have a look at the pull request and comment on it?
>>
>> Thanks,
>> Okke
>>
>>
>>
Re: Pull request
Posted by David Ash <gr...@gmail.com>.
Looks good to me, although I'm no expert. I know Pam is either on or
between vacations, and is really the person to comment on this matter.
Thanks!
David
On Thu, Dec 3, 2015 at 2:28 AM, Okke Harsta <oh...@zilverline.com> wrote:
> Hi,
>
> Our Policy Enforcement Point persists any XACML Result that returns either
> Deny or Indeterminate with a reference to the PolicyIdentifier(s). The
> current Policy and PolicySet implementations do not include the
> PolicyIdentifiers in case the Decision is not Permit or Deny despite the
> Request returning true for Request#getReturnPolicyIdList.
>
> I made a pull request - https://github.com/apache/incubator-openaz/pull/1
> <https://github.com/apache/incubator-openaz/pull/1> - to remedy this and
> added unit tests to verify the new behaviour. Normally I would create an
> issue with a reference to the pull request (and vice versa) but I could not
> create an issue in https://github.com/apache/incubator-openaz <
> https://github.com/apache/incubator-openaz>.
>
> Could anybody have a look at the pull request and comment on it?
>
> Thanks,
> Okke
>
>
>