[GitHub] [pulsar] codelipenghui commented on a change in pull request #9302: Add subscription backlog size info for topicstats.

[GitBox <gi...@apache.org>]

codelipenghui commented on a change in pull request #9302:
URL: https://github.com/apache/pulsar/pull/9302#discussion_r563455692



##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -1826,6 +1826,13 @@
     )
     private boolean exposePreciseBacklogInPrometheus = false;
 
+    @FieldContext(
+            category = CATEGORY_METRICS,
+            doc = "Enable expose the backlog size fro each subscription when generating stats.\n" +
+                    " Locking is used for fetching the status so default to false."
+    )
+    private boolean exposeSubscriptionBacklokSizeInPrometheus = false;

Review comment:
       I think we don't need to introduce a new configuration for this metric? If users enabled the `exposeTopicLevelMetricsInPrometheus`, this metric should be exposed? If it will bring a lot of expenses, we should consider adding a new configuration such as `exposePreciseBacklogInPrometheus`. What do you think @zymap @MarvinCai?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org