You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by gr...@apache.org on 2020/02/27 19:01:16 UTC
[royale-asjs] 08/09: adjust Proxy deleteProperty method to align
javascript closer to swf.
This is an automated email from the ASF dual-hosted git repository.
gregdove pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
commit c3c9f5ecd3c4da744418ec724c3a2ac0d32286fd
Author: greg-dove <gr...@gmail.com>
AuthorDate: Fri Feb 28 07:59:21 2020 +1300
adjust Proxy deleteProperty method to align javascript closer to swf.
---
.../projects/Core/src/main/royale/org/apache/royale/utils/Proxy.as | 4 ++--
.../projects/MXRoyale/src/main/royale/mx/rpc/AbstractService.as | 5 +++--
.../projects/MXRoyale/src/main/royale/mx/rpc/xml/ContentProxy.as | 4 ++--
3 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/frameworks/projects/Core/src/main/royale/org/apache/royale/utils/Proxy.as b/frameworks/projects/Core/src/main/royale/org/apache/royale/utils/Proxy.as
index ef9c855..ed5e48b 100644
--- a/frameworks/projects/Core/src/main/royale/org/apache/royale/utils/Proxy.as
+++ b/frameworks/projects/Core/src/main/royale/org/apache/royale/utils/Proxy.as
@@ -140,9 +140,9 @@ public dynamic class Proxy extends EventDispatcher
return valueMap.hasOwnProperty(propName);
}
- public function deleteProperty(propName:String):void
+ public function deleteProperty(propName:String):Boolean
{
- delete valueMap[propName];
+ return delete valueMap[propName];
}
public function propertyNames():Array
diff --git a/frameworks/projects/MXRoyale/src/main/royale/mx/rpc/AbstractService.as b/frameworks/projects/MXRoyale/src/main/royale/mx/rpc/AbstractService.as
index b7edef0..961d1b2 100644
--- a/frameworks/projects/MXRoyale/src/main/royale/mx/rpc/AbstractService.as
+++ b/frameworks/projects/MXRoyale/src/main/royale/mx/rpc/AbstractService.as
@@ -469,11 +469,12 @@ public dynamic class AbstractService extends Proxy implements IEventDispatcher
}
COMPILE::JS
- override public function deleteProperty(propName:String):void
+ override public function deleteProperty(propName:String):Boolean
{
var message:String = resourceManager.getString(
"rpc", "operationsNotAllowedInService", [ propName ]);
- throw new Error(message);
+ throw new Error(message);
+ // return false;
}
/**
diff --git a/frameworks/projects/MXRoyale/src/main/royale/mx/rpc/xml/ContentProxy.as b/frameworks/projects/MXRoyale/src/main/royale/mx/rpc/xml/ContentProxy.as
index be4db94..f436313 100644
--- a/frameworks/projects/MXRoyale/src/main/royale/mx/rpc/xml/ContentProxy.as
+++ b/frameworks/projects/MXRoyale/src/main/royale/mx/rpc/xml/ContentProxy.as
@@ -189,9 +189,9 @@ public dynamic class ContentProxy extends Proxy
}
COMPILE::JS
- override public function deleteProperty(name:String):void
+ override public function deleteProperty(name:String):Boolean
{
- proxy_deleteProperty(name);
+ return proxy_deleteProperty(name);
}
private function proxy_deleteProperty(name:*):Boolean