You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Mark Chu-Carroll <mc...@twopensource.com> on 2014/05/02 21:46:56 UTC
Review Request 21023: Make "--help" defer to bridged help in the bridged
client executable.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21023/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin and Brian Wickman.
Repository: aurora
Description
-------
Make "--help" defer to bridged help in the bridged client executable.
Diffs
-----
src/main/python/apache/aurora/client/cli/bridge.py 30f1718456deb30632efb57fd8e04d97f74ad00d
Diff: https://reviews.apache.org/r/21023/diff/
Testing
-------
Thanks,
Mark Chu-Carroll
Re: Review Request 21023: Make "--help" defer to bridged help in the
bridged client executable.
Posted by Mark Chu-Carroll <mc...@apache.org>.
Thanks guys! This has been pushed to master.
On Fri, May 2, 2014 at 4:33 PM, David McLaughlin <da...@dmclaughlin.com>wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21023/
>
> Ship it!
>
> Ship It!
>
>
> - David McLaughlin
>
> On May 2nd, 2014, 8:02 p.m. UTC, Mark Chu-Carroll wrote:
> Review request for Aurora, David McLaughlin and Brian Wickman.
> By Mark Chu-Carroll.
>
> *Updated May 2, 2014, 8:02 p.m.*
> *Repository: * aurora
> Description
>
> Make "--help" defer to bridged help in the bridged client executable.
>
> Diffs
>
> - src/main/python/apache/aurora/client/cli/bridge.py
> (30f1718456deb30632efb57fd8e04d97f74ad00d)
>
> View Diff <https://reviews.apache.org/r/21023/diff/>
>
Re: Review Request 21023: Make "--help" defer to bridged help in the bridged
client executable.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21023/#review42055
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On May 2, 2014, 8:02 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21023/
> -----------------------------------------------------------
>
> (Updated May 2, 2014, 8:02 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Make "--help" defer to bridged help in the bridged client executable.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/bridge.py 30f1718456deb30632efb57fd8e04d97f74ad00d
>
> Diff: https://reviews.apache.org/r/21023/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 21023: Make "--help" defer to bridged help in the bridged
client executable.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21023/
-----------------------------------------------------------
(Updated May 2, 2014, 4:02 p.m.)
Review request for Aurora, David McLaughlin and Brian Wickman.
Changes
-------
Get rid of extra nl.
Repository: aurora
Description
-------
Make "--help" defer to bridged help in the bridged client executable.
Diffs (updated)
-----
src/main/python/apache/aurora/client/cli/bridge.py 30f1718456deb30632efb57fd8e04d97f74ad00d
Diff: https://reviews.apache.org/r/21023/diff/
Testing
-------
Thanks,
Mark Chu-Carroll
Re: Review Request 21023: Make "--help" defer to bridged help in the bridged
client executable.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21023/#review42049
-----------------------------------------------------------
Ship it!
src/main/python/apache/aurora/client/cli/bridge.py
<https://reviews.apache.org/r/21023/#comment75787>
there's an extra newline here.
- Brian Wickman
On May 2, 2014, 7:46 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21023/
> -----------------------------------------------------------
>
> (Updated May 2, 2014, 7:46 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Make "--help" defer to bridged help in the bridged client executable.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/bridge.py 30f1718456deb30632efb57fd8e04d97f74ad00d
>
> Diff: https://reviews.apache.org/r/21023/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>