You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by ru...@apache.org on 2023/02/08 11:19:07 UTC

[spark] branch branch-3.4 updated: [SPARK-42267][CONNECT][PYTHON][TESTS][FOLLOWUP] Enable `test_udf_in_filter_on_top_of_outer_join `

This is an automated email from the ASF dual-hosted git repository.

ruifengz pushed a commit to branch branch-3.4
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-3.4 by this push:
     new e5e93c6ee4c [SPARK-42267][CONNECT][PYTHON][TESTS][FOLLOWUP] Enable `test_udf_in_filter_on_top_of_outer_join `
e5e93c6ee4c is described below

commit e5e93c6ee4c074ca9de6c2aef0e2267cefd6e899
Author: Ruifeng Zheng <ru...@apache.org>
AuthorDate: Wed Feb 8 19:18:32 2023 +0800

    [SPARK-42267][CONNECT][PYTHON][TESTS][FOLLOWUP] Enable `test_udf_in_filter_on_top_of_outer_join `
    
    ### What changes were proposed in this pull request?
    Enable `test_udf_in_filter_on_top_of_outer_join `
    
    ### Why are the changes needed?
    for test coverage
    
    ### Does this PR introduce _any_ user-facing change?
    no, test-only
    
    ### How was this patch tested?
    enabled test
    
    Closes #39940 from zhengruifeng/connect_enable_42267.
    
    Authored-by: Ruifeng Zheng <ru...@apache.org>
    Signed-off-by: Ruifeng Zheng <ru...@apache.org>
    (cherry picked from commit 7e8e43b37ad0f083861c5021b679fcbb23d56459)
    Signed-off-by: Ruifeng Zheng <ru...@apache.org>
---
 python/pyspark/sql/tests/connect/test_parity_udf.py | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/python/pyspark/sql/tests/connect/test_parity_udf.py b/python/pyspark/sql/tests/connect/test_parity_udf.py
index dc8e2d63222..f74d21f0d86 100644
--- a/python/pyspark/sql/tests/connect/test_parity_udf.py
+++ b/python/pyspark/sql/tests/connect/test_parity_udf.py
@@ -167,16 +167,11 @@ class UDFParityTests(BaseUDFTestsMixin, ReusedConnectTestCase):
     def test_register_java_udaf(self):
         super().test_register_java_udaf()
 
-    # TODO(SPARK-42267): support left_outer join type
+    # TODO(SPARK-42210): implement `spark.udf`
     @unittest.skip("Fails in Spark Connect, should enable.")
     def test_udf_in_left_outer_join_condition(self):
         super().test_udf_in_left_outer_join_condition()
 
-    # TODO(SPARK-42267): support left_outer join type
-    @unittest.skip("Fails in Spark Connect, should enable.")
-    def test_udf_in_filter_on_top_of_outer_join(self):
-        super().test_udf_in_filter_on_top_of_outer_join()
-
     # TODO(SPARK-42269): support return type as a collection DataType in DDL strings
     @unittest.skip("Fails in Spark Connect, should enable.")
     def test_udf_with_string_return_type(self):


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org