You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "lburgazzoli (via GitHub)" <gi...@apache.org> on 2023/04/04 12:22:46 UTC

[GitHub] [camel-k] lburgazzoli opened a new issue, #4229: kamelet binding: misleading error condition upon initialization error

lburgazzoli opened a new issue, #4229:
URL: https://github.com/apache/camel-k/issues/4229

   According to my understanding, [in case of a failure creating an integration from a kamelet binding](https://github.com/apache/camel-k/blob/d5b9466248fdcc2eedf6489cec978c6b527869ff/pkg/controller/kameletbinding/initialize.go#L52), a condition like the following one will be created:
   
   ```yaml
   - type: "IntegrationError"
     staus: "False"
     reason: "Couldn't create an Integration custom resource"
     message: "..."
   ```
   
   This seems to be a little counterintuitive as type is about an error but the status is false, does this mean that this is not an error ? Also it would be better to let the reason to be machine-readable, UpperCamelCase text indicating the reason for the condition's last transition.
   
   Maybe should be better to use the `Ready` condition or as an alternative to have an `IntegrationCreated` one ? 
   
   ```yaml
   - type: "Ready"
     staus: "False"
     reason: "IntegrationError"
     message: "..."
   ```
   
   or 
   
   ```yaml
   - type: "IntegrationCreated"
     staus: "False"
     reason: "Error"
     message: "..."
   ```
   
   In general conditions must always be present, if not it is assumed to be in an unknown state. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel-k] github-actions[bot] commented on issue #4229: kamelet binding: misleading error condition upon initialization error

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4229:
URL: https://github.com/apache/camel-k/issues/4229#issuecomment-1619287296

   This issue has been automatically marked as stale due to 90 days of inactivity.
   It will be closed if no further activity occurs within 15 days.
   If you think that’s incorrect or the issue should never stale, please simply write any comment.
   Thanks for your contributions!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org