You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Gautam Borad <gb...@gmail.com> on 2015/10/29 14:17:09 UTC
Review Request 39751: AMBARI-13621 : Improve Ranger configs labels as
well as descriptions (Advanced Tab)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39751/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Don Bosco Durai, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Srimanth Gunturi, Velmurugan Periasamy, and Yusaku Sako.
Bugs: AMBARI-13621
https://issues.apache.org/jira/browse/AMBARI-13621
Repository: ambari
Description
-------
Patch contains Ranger config changes in labels and descriptions of few properties.
Diffs
-----
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml 0b02eb4
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml 459d5ec
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 7e7c545
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml 2506743
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml 22e53dc
Diff: https://reviews.apache.org/r/39751/diff/
Testing
-------
Verified updated labels and descriptions and checked a build after changing labels and descriptions of properties.
----------------------------------------------------------------------
Ran 267 tests in 8.046s
OK
----------------------------------------------------------------------
Total run:861
Total errors:0
Total failures:0
OK
Thanks,
Gautam Borad
Re: Review Request 39751: AMBARI-13621 : Improve Ranger configs
labels as well as descriptions (Advanced Tab)
Posted by Gautam Borad <gb...@gmail.com>.
> On Oct. 29, 2015, 5:14 p.m., Velmurugan Periasamy wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml, line 33
> > <https://reviews.apache.org/r/39751/diff/1/?file=1112100#file1112100line33>
> >
> > Change Database root user to Database Admin user - to be consistent with the earlier label change in admin-properties.xml
Fixed in latest patch
- Gautam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39751/#review104447
-----------------------------------------------------------
On Oct. 30, 2015, 5:53 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39751/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2015, 5:53 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Don Bosco Durai, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Srimanth Gunturi, Velmurugan Periasamy, and Yusaku Sako.
>
>
> Bugs: AMBARI-13621
> https://issues.apache.org/jira/browse/AMBARI-13621
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains Ranger config changes in labels and descriptions of few properties.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml 0b02eb4
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml 459d5ec
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 7e7c545
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml 2506743
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml 22e53dc
>
> Diff: https://reviews.apache.org/r/39751/diff/
>
>
> Testing
> -------
>
> Verified updated labels and descriptions and checked a build after changing labels and descriptions of properties.
> ----------------------------------------------------------------------
> Ran 267 tests in 8.046s
>
> OK
> ----------------------------------------------------------------------
> Total run:861
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 39751: AMBARI-13621 : Improve Ranger configs
labels as well as descriptions (Advanced Tab)
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39751/#review104447
-----------------------------------------------------------
Ship it!
Fix it and Ship it!
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml (line 33)
<https://reviews.apache.org/r/39751/#comment162713>
Change Database root user to Database Admin user - to be consistent with the earlier label change in admin-properties.xml
- Velmurugan Periasamy
On Oct. 29, 2015, 1:17 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39751/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2015, 1:17 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Don Bosco Durai, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Srimanth Gunturi, Velmurugan Periasamy, and Yusaku Sako.
>
>
> Bugs: AMBARI-13621
> https://issues.apache.org/jira/browse/AMBARI-13621
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains Ranger config changes in labels and descriptions of few properties.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml 0b02eb4
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml 459d5ec
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 7e7c545
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml 2506743
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml 22e53dc
>
> Diff: https://reviews.apache.org/r/39751/diff/
>
>
> Testing
> -------
>
> Verified updated labels and descriptions and checked a build after changing labels and descriptions of properties.
> ----------------------------------------------------------------------
> Ran 267 tests in 8.046s
>
> OK
> ----------------------------------------------------------------------
> Total run:861
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 39751: AMBARI-13621 : Improve Ranger configs
labels as well as descriptions (Advanced Tab)
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39751/
-----------------------------------------------------------
(Updated Oct. 30, 2015, 5:53 a.m.)
Review request for Ambari, Alejandro Fernandez, Don Bosco Durai, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Srimanth Gunturi, Velmurugan Periasamy, and Yusaku Sako.
Changes
-------
Updated Vel's comment
Bugs: AMBARI-13621
https://issues.apache.org/jira/browse/AMBARI-13621
Repository: ambari
Description
-------
Patch contains Ranger config changes in labels and descriptions of few properties.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/admin-properties.xml 0b02eb4
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml 459d5ec
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 7e7c545
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml 2506743
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml 22e53dc
Diff: https://reviews.apache.org/r/39751/diff/
Testing
-------
Verified updated labels and descriptions and checked a build after changing labels and descriptions of properties.
----------------------------------------------------------------------
Ran 267 tests in 8.046s
OK
----------------------------------------------------------------------
Total run:861
Total errors:0
Total failures:0
OK
Thanks,
Gautam Borad