You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/16 06:48:24 UTC
[GitHub] [incubator-nuttx] ttnie opened a new pull request, #7109: add ci run on sim
ttnie opened a new pull request, #7109:
URL: https://github.com/apache/incubator-nuttx/pull/7109
Signed-off-by: nietingting <ni...@xiaomi.com>
## Summary
add ci run on sim
## Impact
## Testing
on sim
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7109: add ci run on sim
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7109:
URL: https://github.com/apache/incubator-nuttx/pull/7109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ttnie commented on pull request #7109: add ci run on sim
Posted by GitBox <gi...@apache.org>.
ttnie commented on PR #7109:
URL: https://github.com/apache/incubator-nuttx/pull/7109#issuecomment-1255746604
>
Hi acassis,
I try to fix the failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ttnie commented on a diff in pull request #7109: add ci run on sim
Posted by GitBox <gi...@apache.org>.
ttnie commented on code in PR #7109:
URL: https://github.com/apache/incubator-nuttx/pull/7109#discussion_r990573077
##########
boards/sim/sim/sim/configs/ci_ostest/defconfig:
##########
@@ -0,0 +1,76 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
Review Comment:
they're different config between ostest and ci_ostest, do we need to keep ostest? or use ci_ostest instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ttnie commented on a diff in pull request #7109: add ci run on sim
Posted by GitBox <gi...@apache.org>.
ttnie commented on code in PR #7109:
URL: https://github.com/apache/incubator-nuttx/pull/7109#discussion_r990572895
##########
.github/workflows/build.yml:
##########
@@ -161,6 +161,7 @@ jobs:
git config --global --add safe.directory /github/workspace/sources/apps
cd sources/nuttx/tools/ci
./cibuild.sh -A -R -c testlist/${{matrix.boards}}.dat
+ #./cirun.sh -c -x testlist/${{matrix.boards}}.dat
Review Comment:
done.
##########
tools/ci/testrun/README.md:
##########
@@ -0,0 +1,45 @@
+# Requirements
+- Python 3.6 or above
+- pexpect + minicom
+- pytest
+```bash
+sudo apt-get install minicom
+cd env
+pip3 install -r requirements.txt
+```
+# Docs
+[VelaOS Test](https://xiaomi.f.mioffice.cn/docs/dock4opHwhJkzV93W26ytiKCRgg#)
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #7109: add ci run on sim
Posted by GitBox <gi...@apache.org>.
acassis commented on PR #7109:
URL: https://github.com/apache/incubator-nuttx/pull/7109#issuecomment-1254109423
@ttnie it is failing to run the SIM (nuttx file), is this a chicken-egg dilemma ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ttnie commented on a diff in pull request #7109: add ci run on sim
Posted by GitBox <gi...@apache.org>.
ttnie commented on code in PR #7109:
URL: https://github.com/apache/incubator-nuttx/pull/7109#discussion_r990608526
##########
boards/sim/sim/sim/configs/ci_ostest/defconfig:
##########
@@ -0,0 +1,76 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
Review Comment:
merge ostest and ci_ostest to citest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7109: add ci run on sim
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7109:
URL: https://github.com/apache/incubator-nuttx/pull/7109#discussion_r985102090
##########
.github/workflows/build.yml:
##########
@@ -161,6 +161,7 @@ jobs:
git config --global --add safe.directory /github/workspace/sources/apps
cd sources/nuttx/tools/ci
./cibuild.sh -A -R -c testlist/${{matrix.boards}}.dat
+ #./cirun.sh -c -x testlist/${{matrix.boards}}.dat
Review Comment:
revert
##########
boards/sim/sim/sim/configs/ci_ostest/defconfig:
##########
@@ -0,0 +1,76 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
Review Comment:
can we integrate the test into ostest?
##########
tools/testbuild.sh:
##########
@@ -320,7 +320,11 @@ function refresh {
function run {
if [ ${RUN} -ne 0 ]; then
- run_script="$path/run"
+ if [ -f $path/run ] && [ `echo ${path%/} |awk -F '/' '{print $NF}'` == "ci_ostest" ] ; then
+ run_script="$path/../../../../../../tools/ci/cirun.sh"
+ else
+ run_script="$path/run"
Review Comment:
why not lunch the test with run script?
##########
tools/ci/testrun/README.md:
##########
@@ -0,0 +1,45 @@
+# Requirements
+- Python 3.6 or above
+- pexpect + minicom
+- pytest
+```bash
+sudo apt-get install minicom
+cd env
+pip3 install -r requirements.txt
+```
+# Docs
+[VelaOS Test](https://xiaomi.f.mioffice.cn/docs/dock4opHwhJkzV93W26ytiKCRgg#)
Review Comment:
remove the internal link
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] ttnie commented on a diff in pull request #7109: add ci run on sim
Posted by GitBox <gi...@apache.org>.
ttnie commented on code in PR #7109:
URL: https://github.com/apache/incubator-nuttx/pull/7109#discussion_r990572930
##########
tools/testbuild.sh:
##########
@@ -320,7 +320,11 @@ function refresh {
function run {
if [ ${RUN} -ne 0 ]; then
- run_script="$path/run"
+ if [ -f $path/run ] && [ `echo ${path%/} |awk -F '/' '{print $NF}'` == "ci_ostest" ] ; then
+ run_script="$path/../../../../../../tools/ci/cirun.sh"
+ else
+ run_script="$path/run"
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org