You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by Isuru Perera <is...@wso2.com> on 2013/07/23 07:36:52 UTC

Do we need to maintain version in maven property ${apache.stratos.version}?

Hi all,

In pom.xml files, version is specified as

<version>3.0.0-SNAPSHOT</version>

And I have seen the property ${apache.stratos.version} used to refer the
same version. Refer root pom.xml for the property definition.

For example see:
https://git-wip-us.apache.org/repos/asf?p=incubator-stratos.git;a=blob;f=features/cartridge-agent/org.apache.stratos.cartridge.agent.server.feature/pom.xml;hb=905609eb6fda4523dce90aa047e94cd48be0433a

We should be able to use ${project.version}.

I think we should remove ${apache.stratos.version} property as it only
makes things confusing (at least for me).

WDYT?

Thanks!

Best Regards,
-- 
Isuru Perera
Senior Software Engineer | WSO2, Inc. | http://wso2.com/
Lean . Enterprise . Middleware

Twitter: http://twitter.com/chrishantha | LinkedIn:
http://lk.linkedin.com/in/chrishantha/

Re: Do we need to maintain version in maven property ${apache.stratos.version}?

Posted by Isuru Perera <is...@wso2.com>.
I did this change with revision 1d05e82feef9772d667dae6016eb51a94ca32f81


On Tue, Jul 23, 2013 at 11:27 AM, Isuru Haththotuwa <is...@wso2.com> wrote:

> On Tue, Jul 23, 2013 at 11:24 AM, Isuru Perera <is...@wso2.com> wrote:
>
>>
>> On Tue, Jul 23, 2013 at 11:19 AM, Isuru Haththotuwa <is...@wso2.com>wrote:
>>
>>> The idea of keeping ${apache.stratos.version} in root pom is to refer to
>>> that property in everything. But, in referring to the parent pom from a
>>> particular child pom we have to add the version 3.0.0-SNAPSHOT manually. if
>>> there are other places where 3.0.0-SNAPSHOT is added statically, they
>>> should be replaced by the property as we discussed.
>>
>>
>> Since the version is added manually in POMs, we can refer that version.
>> So we can just remove ${apache.stratos.version} and just use
>> ${project.version}.
>>
> +1
>
>>
>>
>> --
>> Isuru Perera
>> Senior Software Engineer | WSO2, Inc. | http://wso2.com/
>> Lean . Enterprise . Middleware
>>
>> Twitter: http://twitter.com/chrishantha | LinkedIn:
>> http://lk.linkedin.com/in/chrishantha/
>>
>
>
>
> --
> Thanks and Regards,
>
> Isuru H.
>
>
>


-- 
Isuru Perera
Senior Software Engineer | WSO2, Inc. | http://wso2.com/
Lean . Enterprise . Middleware

Twitter: http://twitter.com/chrishantha | LinkedIn:
http://lk.linkedin.com/in/chrishantha/

Re: Do we need to maintain version in maven property ${apache.stratos.version}?

Posted by Isuru Haththotuwa <is...@wso2.com>.
On Tue, Jul 23, 2013 at 11:24 AM, Isuru Perera <is...@wso2.com> wrote:

>
> On Tue, Jul 23, 2013 at 11:19 AM, Isuru Haththotuwa <is...@wso2.com>wrote:
>
>> The idea of keeping ${apache.stratos.version} in root pom is to refer to
>> that property in everything. But, in referring to the parent pom from a
>> particular child pom we have to add the version 3.0.0-SNAPSHOT manually. if
>> there are other places where 3.0.0-SNAPSHOT is added statically, they
>> should be replaced by the property as we discussed.
>
>
> Since the version is added manually in POMs, we can refer that version. So
> we can just remove ${apache.stratos.version} and just use
> ${project.version}.
>
+1

>
>
> --
> Isuru Perera
> Senior Software Engineer | WSO2, Inc. | http://wso2.com/
> Lean . Enterprise . Middleware
>
> Twitter: http://twitter.com/chrishantha | LinkedIn:
> http://lk.linkedin.com/in/chrishantha/
>



-- 
Thanks and Regards,

Isuru H.

Re: Do we need to maintain version in maven property ${apache.stratos.version}?

Posted by Isuru Perera <is...@wso2.com>.
On Tue, Jul 23, 2013 at 11:19 AM, Isuru Haththotuwa <is...@wso2.com> wrote:

> The idea of keeping ${apache.stratos.version} in root pom is to refer to
> that property in everything. But, in referring to the parent pom from a
> particular child pom we have to add the version 3.0.0-SNAPSHOT manually. if
> there are other places where 3.0.0-SNAPSHOT is added statically, they
> should be replaced by the property as we discussed.


Since the version is added manually in POMs, we can refer that version. So
we can just remove ${apache.stratos.version} and just use
${project.version}.


-- 
Isuru Perera
Senior Software Engineer | WSO2, Inc. | http://wso2.com/
Lean . Enterprise . Middleware

Twitter: http://twitter.com/chrishantha | LinkedIn:
http://lk.linkedin.com/in/chrishantha/

Re: Do we need to maintain version in maven property ${apache.stratos.version}?

Posted by Isuru Haththotuwa <is...@wso2.com>.
The idea of keeping ${apache.stratos.version} in root pom is to refer to
that property in everything. But, in referring to the parent pom from a
particular child pom we have to add the version 3.0.0-SNAPSHOT manually. if
there are other places where 3.0.0-SNAPSHOT is added statically, they
should be replaced by the property as we discussed.


On Tue, Jul 23, 2013 at 11:06 AM, Isuru Perera <is...@wso2.com> wrote:

> Hi all,
>
> In pom.xml files, version is specified as
>
> <version>3.0.0-SNAPSHOT</version>
>
> And I have seen the property ${apache.stratos.version} used to refer the
> same version. Refer root pom.xml for the property definition.
>
> For example see:
>
> https://git-wip-us.apache.org/repos/asf?p=incubator-stratos.git;a=blob;f=features/cartridge-agent/org.apache.stratos.cartridge.agent.server.feature/pom.xml;hb=905609eb6fda4523dce90aa047e94cd48be0433a
>
> We should be able to use ${project.version}.
>
> I think we should remove ${apache.stratos.version} property as it only
> makes things confusing (at least for me).
>
> WDYT?
>
> Thanks!
>
> Best Regards,
> --
> Isuru Perera
> Senior Software Engineer | WSO2, Inc. | http://wso2.com/
> Lean . Enterprise . Middleware
>
> Twitter: http://twitter.com/chrishantha | LinkedIn:
> http://lk.linkedin.com/in/chrishantha/
>



-- 
Thanks and Regards,

Isuru H.