Re: [PATCH] Issue #2237: Order of parameters in test scripts.

[Madan US <ma...@collab.net>]

> Max Bowsher :
>>> Madan U Sreenivasan wrote:
>>> Sending for the second time. Could some commiter pl. take a look at
>>> this...
[...]
>
> There is a better way. Test for features, not versions. I've committed
> something that does this.
>
Sending the patch for the doc change about dependency on POSIXLY_CORRECT
env var.
[[[
   Issue #2237: Fixed doc

   * subversion/tests/clients/cmdline/README
     (Introduction): Added note about dependency
     introduced by using gnu_getopt().
]]]

Re: [PATCH] Issue #2237: Order of parameters in test scripts.

[Max Bowsher <ma...@ukf.net>]

Madan U Sreenivasan wrote:
> On Fri, 2005-04-01 at 17:22, Julian Foad wrote:
>> Madan US wrote:
>> [...]
>>> +  [ Please make sure that the environment variable POSIXLY_CORRECT,
>>> +    is unset before executing the tests. ]
>>> +
>>
>> [...]
>>  e.g. "Note: the processing of option arguments is less
>> flexible if the environment variable "POSIXLY_CORRECT" is set."
> I agree with your point. But would like to rephrase this...( "less
> flexible" : this is very subjective...) I will resend a patch to this
> effect.


Please, do not.

We do not and should not document the POSIXLY_CORRECT environment variable.

It is a generic setting, affecting every GNU-ish implemenation of getopt in 
any program, as well as many other things besides.

Would you really want every single program that could run other programs to 
redocument PATH ? This is the same situation.

Max.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Issue #2237: Order of parameters in test scripts.

[Madan U Sreenivasan <ma...@collab.net>]

On Fri, 2005-04-01 at 17:22, Julian Foad wrote:
> Madan US wrote:
> [...]
> > +  [ Please make sure that the environment variable POSIXLY_CORRECT,
> > +    is unset before executing the tests. ]
> > +
> 
> [...]
>  e.g. "Note: the processing of option arguments is less 
> flexible if the environment variable "POSIXLY_CORRECT" is set."
I agree with your point. But would like to rephrase this...( "less
flexible" : this is very subjective...) I will resend a patch to this
effect. 

Regards,
Madan.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] Issue #2237: Order of parameters in test scripts.

[Julian Foad <ju...@btopenworld.com>]

Madan US wrote:
> Index: subversion/tests/clients/cmdline/README
> ===================================================================
> --- subversion/tests/clients/cmdline/README	(revision 13734)
> +++ subversion/tests/clients/cmdline/README	(working copy)
> @@ -14,6 +14,9 @@
>  
>  These tests require Python 2.0 or later.
>  
> +  [ Please make sure that the environment variable POSIXLY_CORRECT,
> +    is unset before executing the tests. ]
> +

No, don't just say that.  It will cause the reader to wonder why we impose such 
a restriction, and could be very annoying on systems where POSIXLY_CORRECT must 
be set in order for other things to work properly.  Instead, just say what 
effect this has, e.g. "Note: the processing of option arguments is less 
flexible if the environment variable "POSIXLY_CORRECT" is set."

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org