[GitHub] [echarts] pissang commented on pull request #16348: fix: should check data item in `dataset`

[GitBox <gi...@apache.org>]

pissang commented on pull request #16348:
URL: https://github.com/apache/echarts/pull/16348#issuecomment-1008483949


   @100pah Didn't notice we have a case that can specify state in the dataset. But I think this is not what `dataset` expected to do. Style, states, layout or other chart related configurations should be in the `series`. There are several problems if we mix them in the dataset. 
   
   + The very first purpose and rule when introducing dataset, pure data management component separated from style, is broken
   + It's easy to get messed if we sharing one dataset in different type of series.
   + It's hard for us to do futher optimizations on the dataset because we didn't know how developers will use it when it's not data-only anymore. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org