You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/20 03:23:50 UTC
[GitHub] [kafka] showuon opened a new pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error
showuon opened a new pull request #11086:
URL: https://github.com/apache/kafka/pull/11086
Add `REBALANCE_IN_PROGRESS` error as retriable error for all group API handlers in KIP-699, and tests for it.
1. AlterConsumerGroupOffsetsHandler
2. DeleteConsumerGroupOffsetsHandler
3. DeleteConsumerGroupsHandler
4. DescribeConsumerGroupsHandler
5. ListConsumerGroupOffsetsHandler
6. RemoveMembersFromConsumerGroupHandler
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on a change in pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error
Posted by GitBox <gi...@apache.org>.
dajac commented on a change in pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#discussion_r694876130
##########
File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java
##########
@@ -158,25 +158,24 @@ private void handleError(
Set<CoordinatorKey> groupsToUnmap,
Set<CoordinatorKey> groupsToRetry
) {
+ final String requestErrorMsg = "OffsetCommit request for group id {} returned error {}. Will retry.";
Review comment:
I would rather keep it inline to stay consistent with the other cases.
##########
File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java
##########
@@ -158,25 +158,24 @@ private void handleError(
Set<CoordinatorKey> groupsToUnmap,
Set<CoordinatorKey> groupsToRetry
) {
+ final String requestErrorMsg = "OffsetCommit request for group id {} returned error {}. Will retry.";
switch (error) {
- // If the coordinator is in the middle of loading, then we just need to retry.
+ // If the coordinator is in the middle of loading, or rebalance is in progress, then we just need to retry.
case COORDINATOR_LOAD_IN_PROGRESS:
- log.debug("OffsetCommit request for group id {} failed because the coordinator" +
- " is still in the process of loading state. Will retry.", groupId.idValue);
+ case REBALANCE_IN_PROGRESS:
+ log.debug(requestErrorMsg, groupId.idValue, error);
groupsToRetry.add(groupId);
break;
// If the coordinator is not available, then we unmap and retry.
case COORDINATOR_NOT_AVAILABLE:
case NOT_COORDINATOR:
- log.debug("OffsetCommit request for group id {} returned error {}. Will retry.",
- groupId.idValue, error);
+ log.debug(requestErrorMsg, groupId.idValue, error);
Review comment:
Perhaps, we could say `.... Will rediscover the coordinator and retry.` in this case. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#issuecomment-883108362
@dajac , sorry, I might misunderstand the ticket. So we just change for `AlterConsumerGroupOffsetsHandler` only, is that right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a change in pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error
Posted by GitBox <gi...@apache.org>.
showuon commented on a change in pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#discussion_r694870996
##########
File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java
##########
@@ -159,10 +159,11 @@ private void handleError(
Set<CoordinatorKey> groupsToRetry
) {
switch (error) {
- // If the coordinator is in the middle of loading, then we just need to retry.
+ // If the coordinator is in the middle of loading, or rebalance is in progress, then we just need to retry.
case COORDINATOR_LOAD_IN_PROGRESS:
+ case REBALANCE_IN_PROGRESS:
log.debug("OffsetCommit request for group id {} failed because the coordinator" +
- " is still in the process of loading state. Will retry.", groupId.idValue);
+ " is still in the process of loading state or the group is rebalancing. Will retry.", groupId.idValue);
Review comment:
Make sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#issuecomment-883022752
@dajac @rajinisivaram , please take a look. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#issuecomment-904662073
> excuse me for the delay
Never mind! :)
And thanks for the comment. I've updated the PR. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac merged pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error for AlterConsumerGroupOffsetsHandler
Posted by GitBox <gi...@apache.org>.
dajac merged pull request #11086:
URL: https://github.com/apache/kafka/pull/11086
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#issuecomment-883022752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#issuecomment-883106256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#issuecomment-883106256
@showuon Do we really need to add `REBALANCE_IN_PROGRESS` in all handlers? I thought that we were handling all the errors explicitly now so it should already be there in the relevant handlers. Did we miss cases in your previous PRs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a change in pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error
Posted by GitBox <gi...@apache.org>.
showuon commented on a change in pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#discussion_r672778548
##########
File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java
##########
@@ -3184,8 +3197,111 @@ public void testDeleteConsumerGroupsRetryBackoff() throws Exception {
}
}
+ // this test is testing retriable errors and non-retriable errors in the new broker
@Test
- public void testDeleteConsumerGroupsWithOlderBroker() throws Exception {
+ public void testDeleteConsumerGroupsWithRetriableAndNonretriableErrors() throws Exception {
Review comment:
We used to only have tests for older broker. Add a test for new broker.
##########
File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java
##########
@@ -3184,8 +3197,111 @@ public void testDeleteConsumerGroupsRetryBackoff() throws Exception {
}
}
+ // this test is testing retriable errors and non-retriable errors in the new broker
@Test
- public void testDeleteConsumerGroupsWithOlderBroker() throws Exception {
+ public void testDeleteConsumerGroupsWithRetriableAndNonretriableErrors() throws Exception {
Review comment:
We used to only have tests for older broker for deleteConsumerGroup test. Add a test for new broker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a change in pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error
Posted by GitBox <gi...@apache.org>.
showuon commented on a change in pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#discussion_r672778548
##########
File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java
##########
@@ -3184,8 +3197,111 @@ public void testDeleteConsumerGroupsRetryBackoff() throws Exception {
}
}
+ // this test is testing retriable errors and non-retriable errors in the new broker
@Test
- public void testDeleteConsumerGroupsWithOlderBroker() throws Exception {
+ public void testDeleteConsumerGroupsWithRetriableAndNonretriableErrors() throws Exception {
Review comment:
We used to only have tests for older broker for deleteConsumerGroup test. Add a test for new broker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error for AlterConsumerGroupOffsetsHandler
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#issuecomment-912521901
Thanks for reminding. Updated. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon edited a comment on pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error
Posted by GitBox <gi...@apache.org>.
showuon edited a comment on pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#issuecomment-883108362
@dajac , sorry, I might misunderstand the ticket. So we just change for `AlterConsumerGroupOffsetsHandler` only, is that right? I mean, if we just wanted to change the `REBALANCE_IN_PROGRESS` error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#issuecomment-883106256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#issuecomment-883149180
Yes, you're right. We have handled all kinds of expected errors in previous PRs. So, we should only update for `AlterConsumerGroupOffsetsHandler` here, unless we also want to put `GROUP_AUTHORIZATION_FAILED` into retriable error (but I don't think that makes sense, though).
I've updated the PR. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a change in pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error
Posted by GitBox <gi...@apache.org>.
showuon commented on a change in pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#discussion_r672778548
##########
File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java
##########
@@ -3184,8 +3197,111 @@ public void testDeleteConsumerGroupsRetryBackoff() throws Exception {
}
}
+ // this test is testing retriable errors and non-retriable errors in the new broker
@Test
- public void testDeleteConsumerGroupsWithOlderBroker() throws Exception {
+ public void testDeleteConsumerGroupsWithRetriableAndNonretriableErrors() throws Exception {
Review comment:
We used to only have tests for older broker. Add a test for new broker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#issuecomment-912194029
@dajac , I think this PR is good to get merged. WDYT?
Failed tests are unrelated. Thanks.
```
Build / JDK 11 and Scala 2.13 / kafka.network.DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQuota()
Build / JDK 8 and Scala 2.12 / org.apache.kafka.streams.integration.StoreQueryIntegrationTest.shouldQueryStoresAfterAddingAndRemovingStreamThread
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#issuecomment-912511738
@showuon Yes. Could you update the description of the PR to reflect what has been done? The description is outdated. I will merge it after.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#issuecomment-883022752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on a change in pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error
Posted by GitBox <gi...@apache.org>.
dajac commented on a change in pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#discussion_r694843292
##########
File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java
##########
@@ -159,10 +159,11 @@ private void handleError(
Set<CoordinatorKey> groupsToRetry
) {
switch (error) {
- // If the coordinator is in the middle of loading, then we just need to retry.
+ // If the coordinator is in the middle of loading, or rebalance is in progress, then we just need to retry.
case COORDINATOR_LOAD_IN_PROGRESS:
+ case REBALANCE_IN_PROGRESS:
log.debug("OffsetCommit request for group id {} failed because the coordinator" +
- " is still in the process of loading state. Will retry.", groupId.idValue);
+ " is still in the process of loading state or the group is rebalancing. Will retry.", groupId.idValue);
Review comment:
I wonder if it would be preferable to use a more generic message which clearly mention the error encountered: `OffsetCommit request for group id {} returned error {}. Will retry.`. Without mentioning the received error, we don't really know what happened so the log is not that useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a change in pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error
Posted by GitBox <gi...@apache.org>.
showuon commented on a change in pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#discussion_r672778548
##########
File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java
##########
@@ -3184,8 +3197,111 @@ public void testDeleteConsumerGroupsRetryBackoff() throws Exception {
}
}
+ // this test is testing retriable errors and non-retriable errors in the new broker
@Test
- public void testDeleteConsumerGroupsWithOlderBroker() throws Exception {
+ public void testDeleteConsumerGroupsWithRetriableAndNonretriableErrors() throws Exception {
Review comment:
We used to only have tests for older broker. Add a test for new broker.
##########
File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java
##########
@@ -3184,8 +3197,111 @@ public void testDeleteConsumerGroupsRetryBackoff() throws Exception {
}
}
+ // this test is testing retriable errors and non-retriable errors in the new broker
@Test
- public void testDeleteConsumerGroupsWithOlderBroker() throws Exception {
+ public void testDeleteConsumerGroupsWithRetriableAndNonretriableErrors() throws Exception {
Review comment:
We used to only have tests for older broker for deleteConsumerGroup test. Add a test for new broker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac commented on pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error
Posted by GitBox <gi...@apache.org>.
dajac commented on pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#issuecomment-883146836
> @dajac , sorry, I might misunderstand the ticket. So we just change for `AlterConsumerGroupOffsetsHandler` only, is that right? I mean, if we just wanted to change the `REBALANCE_IN_PROGRESS` error.
I haven't checked the handlers so I don't know :). We need to check where `REBALANCE_IN_PROGRESS` is actually expected and decide if making it retryable make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#issuecomment-905139875
@dajac , thanks for the comment. I've updated the PR. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#issuecomment-883104088
Failed tests are unrelated. Thanks.
```
Build / ARM / org.apache.kafka.clients.ClientUtilsTest.testResolveDnsLookup()
Build / ARM / org.apache.kafka.clients.ClientUtilsTest.testResolveDnsLookup()
Build / JDK 8 and Scala 2.12 / org.apache.kafka.clients.ClientUtilsTest.testResolveDnsLookup()
Build / JDK 8 and Scala 2.12 / org.apache.kafka.clients.ClientUtilsTest.testResolveDnsLookup()
Build / JDK 8 and Scala 2.12 / kafka.api.ConsumerBounceTest.testCloseDuringRebalance()
Build / JDK 8 and Scala 2.12 / kafka.api.ConsumerBounceTest.testCloseDuringRebalance()
Build / JDK 11 and Scala 2.13 / org.apache.kafka.clients.ClientUtilsTest.testResolveDnsLookup()
Build / JDK 11 and Scala 2.13 / org.apache.kafka.clients.ClientUtilsTest.testResolveDnsLookup()
Build / JDK 11 and Scala 2.13 / kafka.api.ConsumerBounceTest.testCloseDuringRebalance()
Build / JDK 11 and Scala 2.13 / kafka.api.TransactionsTest.testBumpTransactionalEpoch()
Build / JDK 16 and Scala 2.13 / org.apache.kafka.clients.ClientUtilsTest.testResolveDnsLookup()
Build / JDK 16 and Scala 2.13 / org.apache.kafka.clients.ClientUtilsTest.testResolveDnsLookup()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a change in pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error
Posted by GitBox <gi...@apache.org>.
showuon commented on a change in pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#discussion_r695353891
##########
File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AlterConsumerGroupOffsetsHandler.java
##########
@@ -158,25 +158,24 @@ private void handleError(
Set<CoordinatorKey> groupsToUnmap,
Set<CoordinatorKey> groupsToRetry
) {
+ final String requestErrorMsg = "OffsetCommit request for group id {} returned error {}. Will retry.";
switch (error) {
- // If the coordinator is in the middle of loading, then we just need to retry.
+ // If the coordinator is in the middle of loading, or rebalance is in progress, then we just need to retry.
case COORDINATOR_LOAD_IN_PROGRESS:
- log.debug("OffsetCommit request for group id {} failed because the coordinator" +
- " is still in the process of loading state. Will retry.", groupId.idValue);
+ case REBALANCE_IN_PROGRESS:
+ log.debug(requestErrorMsg, groupId.idValue, error);
groupsToRetry.add(groupId);
break;
// If the coordinator is not available, then we unmap and retry.
case COORDINATOR_NOT_AVAILABLE:
case NOT_COORDINATOR:
- log.debug("OffsetCommit request for group id {} returned error {}. Will retry.",
- groupId.idValue, error);
+ log.debug(requestErrorMsg, groupId.idValue, error);
Review comment:
Good to me. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon edited a comment on pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error
Posted by GitBox <gi...@apache.org>.
showuon edited a comment on pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#issuecomment-883108362
@dajac , sorry, I might misunderstand the ticket. So we just change for `AlterConsumerGroupOffsetsHandler` only, is that right? I mean, if we just wanted to change the `REBALANCE_IN_PROGRESS` error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon edited a comment on pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error
Posted by GitBox <gi...@apache.org>.
showuon edited a comment on pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#issuecomment-883108362
@dajac , sorry, I might misunderstand the ticket. So we just change for `AlterConsumerGroupOffsetsHandler` only, is that right? I mean, if we just wanted to change the `REBALANCE_IN_PROGRESS` error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11086: KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11086:
URL: https://github.com/apache/kafka/pull/11086#issuecomment-887980048
@dajac , could you help take a look at this PR? Also, do we want to put this PR into v3.0? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org