[GitHub] [helix] jiajunwang commented on a change in pull request #632: Asynchronously calculating the Baseline

[GitBox <gi...@apache.org>]

jiajunwang commented on a change in pull request #632: Asynchronously calculating the Baseline
URL: https://github.com/apache/helix/pull/632#discussion_r351946102
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/monitoring/metrics/implementation/RebalanceLatencyGauge.java
 ##########
 @@ -30,6 +31,7 @@
   private static final Logger LOG = LoggerFactory.getLogger(RebalanceLatencyGauge.class);
   private static final long VALUE_NOT_SET = -1;
   private long _lastEmittedMetricValue = VALUE_NOT_SET;
+  private final ThreadLocal<Long> _startTime;
 
 Review comment:
   Note the 5th point in the description:
   "Enable the latency metric to report correct numbers even used in multi-threads."
   
   If you don't understand, we can talk. I will split this part into a separate PR later. Maybe you will understand by then. And I totally agree with you that we should minimize the change. That is what I'm doing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org