You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/11/16 09:17:06 UTC
[GitHub] [skywalking] wu-sheng opened a new pull request #5849: Support `sideCar.internalErrorCode` in the sources
wu-sheng opened a new pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849
<!--
⚠️ Please make sure to read this template first, pull requests that doesn't accord with this template
may be closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly about why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking/blob/master/docs/en/guides/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
The sidecar is a common concept today, as the service mesh has been the next-generation infrastructure, no matter in k8s or out. I found we need to support this in the mesh telemetry internal format to support defining metrics in the mesh case.
There are 2 major changes in the PR
1. Nested classes definition is not supported in the previous OAL core, so I added them. It should support any nested class.
2. Support `sideCar.internalErrorCode` in the Service, ServiceInstance, Endpoint, ServiceRelation, and ServiceInstanceRelation sources, then you could have OAL scripts like this
```
service_cpm_sidecar = from(Service.*).filter(sideCar.internalErrorCode != "").cpm();
service_sla_sidecar = from(Service.*).percent(sideCar.internalErrorCode != "");
```
The current Istio+Envoy mesh telemetry's `sideCar.internalErrorCode` is mapping to envoy's v2 ALS definition, https://www.envoyproxy.io/docs/envoy/latest/api-v2/data/accesslog/v2/accesslog.proto#data-accesslog-v2-responseflags.
At last, I didn't change anything in the default OAL, all these two features are open to the users. If they want to this, they could add new OAL scripts, and set up the UI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (16924b9) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `21.39%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 29.80% -21.40%
+ Complexity 3456 2013 -1443
=============================================
Files 1654 887 -767
Lines 35436 22095 -13341
Branches 3861 2131 -1730
=============================================
- Hits 18144 6586 -11558
+ Misses 16393 15014 -1379
+ Partials 899 495 -404
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1287 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (16924b9) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `13.09%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 38.10% -13.10%
+ Complexity 3456 2697 -759
=============================================
Files 1654 914 -740
Lines 35436 22573 -12863
Branches 3861 2193 -1668
=============================================
- Hits 18144 8602 -9542
+ Misses 16393 13231 -3162
+ Partials 899 740 -159
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1234 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (71919a6) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `51.20%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 0.00% -51.21%
============================================
Files 1654 167 -1487
Lines 35436 4067 -31369
Branches 3861 474 -3387
============================================
- Hits 18144 0 -18144
+ Misses 16393 4067 -12326
+ Partials 899 0 -899
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1617 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `6.62%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 44.57% -6.63%
+ Complexity 3456 3005 -451
============================================
Files 1654 881 -773
Lines 35436 21987 -13449
Branches 3861 2104 -1757
============================================
- Hits 18144 9801 -8343
+ Misses 16393 11341 -5052
+ Partials 899 845 -54
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1211 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `12.00%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 39.19% -12.01%
+ Complexity 3456 2230 -1226
=============================================
Files 1654 755 -899
Lines 35436 19076 -16360
Branches 3861 1772 -2089
=============================================
- Hits 18144 7477 -10667
+ Misses 16393 11014 -5379
+ Partials 899 585 -314
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1271 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `13.26%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 37.93% -13.27%
+ Complexity 3456 2517 -939
=============================================
Files 1654 900 -754
Lines 35436 22602 -12834
Branches 3861 2182 -1679
=============================================
- Hits 18144 8575 -9569
+ Misses 16393 13395 -2998
+ Partials 899 632 -267
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1234 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `8.21%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 42.98% -8.22%
+ Complexity 3456 2418 -1038
============================================
Files 1654 755 -899
Lines 35436 19085 -16351
Branches 3861 1772 -2089
============================================
- Hits 18144 8204 -9940
+ Misses 16393 10255 -6138
+ Partials 899 626 -273
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1257 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `6.81%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 44.38% -6.82%
+ Complexity 3456 3008 -448
============================================
Files 1654 885 -769
Lines 35436 22127 -13309
Branches 3861 2131 -1730
============================================
- Hits 18144 9821 -8323
+ Misses 16393 11462 -4931
+ Partials 899 844 -55
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1207 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `13.38%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 37.82% -13.39%
+ Complexity 3456 2517 -939
=============================================
Files 1654 905 -749
Lines 35436 22672 -12764
Branches 3861 2184 -1677
=============================================
- Hits 18144 8575 -9569
+ Misses 16393 13465 -2928
+ Partials 899 632 -267
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1234 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (71919a6) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `25.26%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 25.93% -25.27%
+ Complexity 3456 1802 -1654
=============================================
Files 1654 898 -756
Lines 35436 22132 -13304
Branches 3861 2112 -1749
=============================================
- Hits 18144 5740 -12404
+ Misses 16393 16001 -392
+ Partials 899 391 -508
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1303 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `6.55%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 44.64% -6.56%
+ Complexity 3456 3007 -449
============================================
Files 1654 881 -773
Lines 35436 21995 -13441
Branches 3861 2119 -1742
============================================
- Hits 18144 9820 -8324
+ Misses 16393 11331 -5062
+ Partials 899 844 -55
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1208 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (71919a6) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `51.20%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 0.00% -51.21%
============================================
Files 1654 168 -1486
Lines 35436 4078 -31358
Branches 3861 474 -3387
============================================
- Hits 18144 0 -18144
+ Misses 16393 4078 -12315
+ Partials 899 0 -899
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1617 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (71919a6) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `10.49%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 40.71% -10.50%
+ Complexity 3456 2663 -793
=============================================
Files 1654 915 -739
Lines 35436 22851 -12585
Branches 3861 2195 -1666
=============================================
- Hits 18144 9303 -8841
+ Misses 16393 12863 -3530
+ Partials 899 685 -214
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1224 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (16924b9) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `12.37%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 38.82% -12.38%
+ Complexity 3456 2697 -759
=============================================
Files 1654 892 -762
Lines 35436 22157 -13279
Branches 3861 2135 -1726
=============================================
- Hits 18144 8602 -9542
+ Misses 16393 12815 -3578
+ Partials 899 740 -159
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1233 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `7.78%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 43.42% -7.79%
+ Complexity 3456 3008 -448
============================================
Files 1654 914 -740
Lines 35436 22618 -12818
Branches 3861 2194 -1667
============================================
- Hits 18144 9821 -8323
+ Misses 16393 11953 -4440
+ Partials 899 844 -55
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1206 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (16924b9) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `21.39%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 29.80% -21.40%
+ Complexity 3456 2011 -1445
=============================================
Files 1654 886 -768
Lines 35436 22083 -13353
Branches 3861 2129 -1732
=============================================
- Hits 18144 6582 -11562
+ Misses 16393 15005 -1388
+ Partials 899 496 -403
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1287 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (71919a6) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `9.89%`.
> The diff coverage is `34.48%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 41.31% -9.90%
+ Complexity 3456 2691 -765
============================================
Files 1654 918 -736
Lines 35436 22960 -12476
Branches 3861 2207 -1654
============================================
- Hits 18144 9485 -8659
+ Misses 16393 12773 -3620
+ Partials 899 702 -197
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `87.09% <71.42%> (-0.16%)` | `14.00 <0.00> (ø)` | |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1224 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on a change in pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#discussion_r524327605
##########
File path: docs/en/concepts-and-designs/scope-definitions.md
##########
@@ -29,6 +29,7 @@ Calculate the metrics data from each request of the service.
| responseCode | Represent the response code of HTTP response, if this request is the HTTP call | | int|
| type | Represent the type of each request. Such as: Database, HTTP, RPC, gRPC. | | enum |
| tags | Represent the labels of each request and each value is made up with the `TagKey:TagValue` in the segment. | | `List<String>` |
+| sideCar.internalErrorCode | Represent the sidecar/proxy internal error code, the value bases on the implementation. | | string|
Review comment:
FWIK, "proxy" is a more general name than `sidecar`. The latter one is often put together with "gateway" as Istio does, and therefore I prefer to use "proxy.internalErrorCode" instead of "sidecar.internalErrorCode".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `5.49%`.
> The diff coverage is `34.48%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 45.70% -5.50%
+ Complexity 3456 3212 -244
============================================
Files 1654 935 -719
Lines 35436 23251 -12185
Branches 3861 2254 -1607
============================================
- Hits 18144 10628 -7516
+ Misses 16393 11716 -4677
- Partials 899 907 +8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `87.09% <71.42%> (-0.16%)` | `14.00 <0.00> (ø)` | |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1188 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#discussion_r524355984
##########
File path: docs/en/concepts-and-designs/scope-definitions.md
##########
@@ -29,6 +29,7 @@ Calculate the metrics data from each request of the service.
| responseCode | Represent the response code of HTTP response, if this request is the HTTP call | | int|
| type | Represent the type of each request. Such as: Database, HTTP, RPC, gRPC. | | enum |
| tags | Represent the labels of each request and each value is made up with the `TagKey:TagValue` in the segment. | | `List<String>` |
+| sideCar.internalErrorCode | Represent the sidecar/proxy internal error code, the value bases on the implementation. | | string|
Review comment:
Fixed the comments and docs. Others are unchanged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (16924b9) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `8.05%`.
> The diff coverage is `44.82%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 43.14% -8.06%
+ Complexity 3456 2697 -759
============================================
Files 1654 1653 -1
Lines 35436 35558 +122
Branches 3861 3868 +7
============================================
- Hits 18144 15341 -2803
- Misses 16393 19296 +2903
- Partials 899 921 +22
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `50.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.41% <0.00%> (-80.84%)` | `2.00 <0.00> (-12.00)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `51.92% <15.90%> (-27.11%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `75.00% <75.00%> (ø)` | `7.00 <4.00> (+4.00)` | |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `100.00% <100.00%> (+38.46%)` | `4.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `93.10% <100.00%> (ø)` | `30.00 <2.00> (ø)` | |
| ... and [197 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `7.08%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 44.11% -7.09%
+ Complexity 3456 3008 -448
============================================
Files 1654 894 -760
Lines 35436 22260 -13176
Branches 3861 2144 -1717
============================================
- Hits 18144 9821 -8323
+ Misses 16393 11595 -4798
+ Partials 899 844 -55
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1205 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `5.49%`.
> The diff coverage is `34.48%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 45.70% -5.50%
+ Complexity 3456 3212 -244
============================================
Files 1654 935 -719
Lines 35436 23251 -12185
Branches 3861 2254 -1607
============================================
- Hits 18144 10628 -7516
+ Misses 16393 11716 -4677
- Partials 899 907 +8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `87.09% <71.42%> (-0.16%)` | `14.00 <0.00> (ø)` | |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1188 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (71919a6) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `11.54%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 39.65% -11.55%
+ Complexity 3456 2620 -836
=============================================
Files 1654 915 -739
Lines 35436 22851 -12585
Branches 3861 2195 -1666
=============================================
- Hits 18144 9061 -9083
+ Misses 16393 13107 -3286
+ Partials 899 683 -216
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1226 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#discussion_r524029956
##########
File path: oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/LogEntry2MetricsAdapter.java
##########
@@ -164,4 +169,52 @@ protected static String parseTLS(final TLSProperties properties) {
return M_TLS;
}
+ /**
+ * Refer to https://www.envoyproxy.io/docs/envoy/latest/api-v2/data/accesslog/v2/accesslog.proto#data-accesslog-v2-responseflags
+ *
+ * @param responseFlags in the ALS v2
+ * @return empty string if no internal error code, or literal string representing the code.
+ */
+ protected static String parseInternalErrorCode(final ResponseFlags responseFlags) {
+ if (responseFlags != null) {
+ if (responseFlags.getFailedLocalHealthcheck()) {
+ return "failed_local_healthcheck";
+ } else if (responseFlags.getNoHealthyUpstream()) {
+ return "no_healthy_upstream";
+ } else if (responseFlags.getUpstreamRequestTimeout()) {
+ return "upstream_request_timeout";
+ } else if (responseFlags.getLocalReset()) {
+ return "local_reset";
+ } else if (responseFlags.getUpstreamConnectionFailure()) {
+ return "upstream_connection_failure";
+ } else if (responseFlags.getUpstreamConnectionTermination()) {
+ return "upstream_connection_termination";
+ } else if (responseFlags.getUpstreamOverflow()) {
+ return "upstream_overflow";
+ } else if (responseFlags.getNoRouteFound()) {
+ return "no_route_found";
+ } else if (responseFlags.getDelayInjected()) {
+ return "delay_injected";
+ } else if (responseFlags.getFaultInjected()) {
+ return "fault_injected";
+ } else if (responseFlags.getRateLimited()) {
+ return "rate_limited";
+ } else if (responseFlags.getUnauthorizedDetails() != null) {
+ return "unauthorized_details";
+ } else if (responseFlags.getRateLimitServiceError()) {
+ return "rate_limit_service_error";
+ } else if (responseFlags.getDownstreamConnectionTermination()) {
+ return "downstream_connection_termination";
+ } else if (responseFlags.getUpstreamRetryLimitExceeded()) {
+ return "upstream_retry_limit_exceeded";
+ } else if (responseFlags.getStreamIdleTimeout()) {
+ return "stream_idle_timeout";
+ } else if (responseFlags.getInvalidEnvoyRequestHeaders()) {
+ return "invalid_envoy_request_headers";
+ } else if (responseFlags.getDownstreamProtocolError()) {
+ return "downstream_protocol_error";
+ }
Review comment:
@lizan Does this kind of conversion make sense? Is there any chance of having multiple error codes? Even if so, doesn't it matter or have priority?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (71919a6) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **increase** coverage by `0.16%`.
> The diff coverage is `34.48%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
+ Coverage 51.20% 51.36% +0.16%
- Complexity 3456 3465 +9
============================================
Files 1654 919 -735
Lines 35436 23030 -12406
Branches 3861 2213 -1648
============================================
- Hits 18144 11830 -6314
+ Misses 16393 10241 -6152
- Partials 899 959 +60
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `87.09% <71.42%> (-0.16%)` | `14.00 <0.00> (ø)` | |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1162 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `5.41%`.
> The diff coverage is `34.48%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 45.78% -5.42%
+ Complexity 3456 3212 -244
============================================
Files 1654 934 -720
Lines 35436 23212 -12224
Branches 3861 2253 -1608
============================================
- Hits 18144 10628 -7516
+ Misses 16393 11677 -4716
- Partials 899 907 +8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `87.09% <71.42%> (-0.16%)` | `14.00 <0.00> (ø)` | |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1187 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `7.78%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 43.42% -7.79%
+ Complexity 3456 2439 -1017
============================================
Files 1654 755 -899
Lines 35436 19085 -16351
Branches 3861 1772 -2089
============================================
- Hits 18144 8287 -9857
+ Misses 16393 10171 -6222
+ Partials 899 627 -272
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1256 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `3.63%`.
> The diff coverage is `44.82%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 47.56% -3.64%
+ Complexity 3456 2636 -820
============================================
Files 1654 1655 +1
Lines 35436 35527 +91
Branches 3861 3874 +13
============================================
- Hits 18144 16898 -1246
- Misses 16393 17708 +1315
- Partials 899 921 +22
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `50.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.41% <0.00%> (-80.84%)` | `2.00 <0.00> (-12.00)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `51.92% <15.90%> (-27.11%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `75.00% <75.00%> (ø)` | `7.00 <4.00> (+4.00)` | |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `100.00% <100.00%> (+38.46%)` | `4.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `93.10% <100.00%> (ø)` | `30.00 <2.00> (ø)` | |
| ... and [150 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (16924b9) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `21.37%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 29.82% -21.38%
+ Complexity 3456 2013 -1443
=============================================
Files 1654 886 -768
Lines 35436 22084 -13352
Branches 3861 2131 -1730
=============================================
- Hits 18144 6586 -11558
+ Misses 16393 15003 -1390
+ Partials 899 495 -404
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1287 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#discussion_r524031233
##########
File path: oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/LogEntry2MetricsAdapter.java
##########
@@ -164,4 +169,52 @@ protected static String parseTLS(final TLSProperties properties) {
return M_TLS;
}
+ /**
+ * Refer to https://www.envoyproxy.io/docs/envoy/latest/api-v2/data/accesslog/v2/accesslog.proto#data-accesslog-v2-responseflags
+ *
+ * @param responseFlags in the ALS v2
+ * @return empty string if no internal error code, or literal string representing the code.
+ */
+ protected static String parseInternalErrorCode(final ResponseFlags responseFlags) {
+ if (responseFlags != null) {
+ if (responseFlags.getFailedLocalHealthcheck()) {
+ return "failed_local_healthcheck";
+ } else if (responseFlags.getNoHealthyUpstream()) {
+ return "no_healthy_upstream";
+ } else if (responseFlags.getUpstreamRequestTimeout()) {
+ return "upstream_request_timeout";
+ } else if (responseFlags.getLocalReset()) {
+ return "local_reset";
+ } else if (responseFlags.getUpstreamConnectionFailure()) {
+ return "upstream_connection_failure";
+ } else if (responseFlags.getUpstreamConnectionTermination()) {
+ return "upstream_connection_termination";
+ } else if (responseFlags.getUpstreamOverflow()) {
+ return "upstream_overflow";
+ } else if (responseFlags.getNoRouteFound()) {
+ return "no_route_found";
+ } else if (responseFlags.getDelayInjected()) {
+ return "delay_injected";
+ } else if (responseFlags.getFaultInjected()) {
+ return "fault_injected";
+ } else if (responseFlags.getRateLimited()) {
+ return "rate_limited";
+ } else if (responseFlags.getUnauthorizedDetails() != null) {
+ return "unauthorized_details";
+ } else if (responseFlags.getRateLimitServiceError()) {
+ return "rate_limit_service_error";
+ } else if (responseFlags.getDownstreamConnectionTermination()) {
+ return "downstream_connection_termination";
+ } else if (responseFlags.getUpstreamRetryLimitExceeded()) {
+ return "upstream_retry_limit_exceeded";
+ } else if (responseFlags.getStreamIdleTimeout()) {
+ return "stream_idle_timeout";
+ } else if (responseFlags.getInvalidEnvoyRequestHeaders()) {
+ return "invalid_envoy_request_headers";
+ } else if (responseFlags.getDownstreamProtocolError()) {
+ return "downstream_protocol_error";
+ }
Review comment:
To @ZackButcher too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (16924b9) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `13.09%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 38.10% -13.10%
+ Complexity 3456 2697 -759
=============================================
Files 1654 914 -740
Lines 35436 22573 -12863
Branches 3861 2193 -1668
=============================================
- Hits 18144 8602 -9542
+ Misses 16393 13231 -3162
+ Partials 899 740 -159
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1234 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `5.49%`.
> The diff coverage is `34.48%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 45.70% -5.50%
+ Complexity 3456 3212 -244
============================================
Files 1654 935 -719
Lines 35436 23251 -12185
Branches 3861 2254 -1607
============================================
- Hits 18144 10628 -7516
+ Misses 16393 11716 -4677
- Partials 899 907 +8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `87.09% <71.42%> (-0.16%)` | `14.00 <0.00> (ø)` | |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1188 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (71919a6) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `10.37%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 40.82% -10.38%
+ Complexity 3456 2670 -786
=============================================
Files 1654 915 -739
Lines 35436 22851 -12585
Branches 3861 2195 -1666
=============================================
- Hits 18144 9330 -8814
+ Misses 16393 12834 -3559
+ Partials 899 687 -212
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1224 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (16924b9) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `13.09%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 38.10% -13.10%
+ Complexity 3456 2697 -759
=============================================
Files 1654 914 -740
Lines 35436 22573 -12863
Branches 3861 2193 -1668
=============================================
- Hits 18144 8602 -9542
+ Misses 16393 13231 -3162
+ Partials 899 740 -159
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1234 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `6.98%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 44.21% -6.99%
+ Complexity 3456 3008 -448
============================================
Files 1654 891 -763
Lines 35436 22212 -13224
Branches 3861 2140 -1721
============================================
- Hits 18144 9821 -8323
+ Misses 16393 11547 -4846
+ Partials 899 844 -55
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1207 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `14.06%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 37.13% -14.07%
+ Complexity 3456 2469 -987
=============================================
Files 1654 900 -754
Lines 35436 22590 -12846
Branches 3861 2182 -1679
=============================================
- Hits 18144 8389 -9755
+ Misses 16393 13569 -2824
+ Partials 899 632 -267
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1244 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `7.78%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 43.42% -7.79%
+ Complexity 3456 3008 -448
============================================
Files 1654 914 -740
Lines 35436 22618 -12818
Branches 3861 2194 -1667
============================================
- Hits 18144 9821 -8323
+ Misses 16393 11953 -4440
+ Partials 899 844 -55
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1206 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (16924b9) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `13.09%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 38.10% -13.10%
+ Complexity 3456 2697 -759
=============================================
Files 1654 914 -740
Lines 35436 22573 -12863
Branches 3861 2193 -1668
=============================================
- Hits 18144 8602 -9542
+ Misses 16393 13231 -3162
+ Partials 899 740 -159
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1234 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `7.09%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 44.10% -7.10%
+ Complexity 3456 3008 -448
============================================
Files 1654 896 -758
Lines 35436 22266 -13170
Branches 3861 2144 -1717
============================================
- Hits 18144 9821 -8323
+ Misses 16393 11601 -4792
+ Partials 899 844 -55
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1205 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `15.31%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 35.88% -15.32%
+ Complexity 3456 2032 -1424
=============================================
Files 1654 738 -916
Lines 35436 18597 -16839
Branches 3861 1726 -2135
=============================================
- Hits 18144 6674 -11470
+ Misses 16393 11414 -4979
+ Partials 899 509 -390
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1291 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#discussion_r524329962
##########
File path: docs/en/concepts-and-designs/scope-definitions.md
##########
@@ -29,6 +29,7 @@ Calculate the metrics data from each request of the service.
| responseCode | Represent the response code of HTTP response, if this request is the HTTP call | | int|
| type | Represent the type of each request. Such as: Database, HTTP, RPC, gRPC. | | enum |
| tags | Represent the labels of each request and each value is made up with the `TagKey:TagValue` in the segment. | | `List<String>` |
+| sideCar.internalErrorCode | Represent the sidecar/proxy internal error code, the value bases on the implementation. | | string|
Review comment:
As the attachment, I don't want it to be a `proxy`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `4.94%`.
> The diff coverage is `44.82%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 46.25% -4.95%
+ Complexity 3456 2517 -939
============================================
Files 1654 1655 +1
Lines 35436 35515 +79
Branches 3861 3874 +13
============================================
- Hits 18144 16429 -1715
- Misses 16393 18162 +1769
- Partials 899 924 +25
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `50.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.41% <0.00%> (-80.84%)` | `2.00 <0.00> (-12.00)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `51.92% <15.90%> (-27.11%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `75.00% <75.00%> (ø)` | `7.00 <4.00> (+4.00)` | |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `100.00% <100.00%> (+38.46%)` | `4.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `93.10% <100.00%> (ø)` | `30.00 <2.00> (ø)` | |
| ... and [174 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (16924b9) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `12.35%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 38.85% -12.36%
+ Complexity 3456 2697 -759
=============================================
Files 1654 889 -765
Lines 35436 22141 -13295
Branches 3861 2135 -1726
=============================================
- Hits 18144 8602 -9542
+ Misses 16393 12799 -3594
+ Partials 899 740 -159
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1233 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `7.78%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 43.42% -7.79%
+ Complexity 3456 3008 -448
============================================
Files 1654 914 -740
Lines 35436 22618 -12818
Branches 3861 2194 -1667
============================================
- Hits 18144 9821 -8323
+ Misses 16393 11953 -4440
+ Partials 899 844 -55
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1206 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `6.96%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 44.23% -6.97%
+ Complexity 3456 3008 -448
============================================
Files 1654 890 -764
Lines 35436 22201 -13235
Branches 3861 2140 -1721
============================================
- Hits 18144 9821 -8323
+ Misses 16393 11536 -4857
+ Partials 899 844 -55
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1207 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (16924b9) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `51.20%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 0.00% -51.21%
============================================
Files 1654 161 -1493
Lines 35436 3963 -31473
Branches 3861 456 -3405
============================================
- Hits 18144 0 -18144
+ Misses 16393 3963 -12430
+ Partials 899 0 -899
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1617 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (16924b9) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `12.35%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 38.85% -12.36%
+ Complexity 3456 2697 -759
=============================================
Files 1654 889 -765
Lines 35436 22141 -13295
Branches 3861 2135 -1726
=============================================
- Hits 18144 8602 -9542
+ Misses 16393 12799 -3594
+ Partials 899 740 -159
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1233 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (16924b9) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `13.09%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 38.10% -13.10%
+ Complexity 3456 2697 -759
=============================================
Files 1654 914 -740
Lines 35436 22573 -12863
Branches 3861 2193 -1668
=============================================
- Hits 18144 8602 -9542
+ Misses 16393 13231 -3162
+ Partials 899 740 -159
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1234 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (16924b9) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `21.45%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 29.74% -21.46%
+ Complexity 3456 2013 -1443
=============================================
Files 1654 889 -765
Lines 35436 22141 -13295
Branches 3861 2135 -1726
=============================================
- Hits 18144 6586 -11558
+ Misses 16393 15060 -1333
+ Partials 899 495 -404
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1287 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `7.10%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 44.09% -7.11%
+ Complexity 3456 3008 -448
============================================
Files 1654 897 -757
Lines 35436 22271 -13165
Branches 3861 2144 -1717
============================================
- Hits 18144 9821 -8323
+ Misses 16393 11606 -4787
+ Partials 899 844 -55
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1205 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (16924b9) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `12.38%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 38.81% -12.39%
+ Complexity 3456 2694 -762
=============================================
Files 1654 889 -765
Lines 35436 22141 -13295
Branches 3861 2135 -1726
=============================================
- Hits 18144 8594 -9550
+ Misses 16393 12807 -3586
+ Partials 899 740 -159
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1233 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (16924b9) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `12.37%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 38.83% -12.38%
+ Complexity 3456 2697 -759
=============================================
Files 1654 891 -763
Lines 35436 22152 -13284
Branches 3861 2135 -1726
=============================================
- Hits 18144 8602 -9542
+ Misses 16393 12810 -3583
+ Partials 899 740 -159
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1233 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (16924b9) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `51.20%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 0.00% -51.21%
============================================
Files 1654 163 -1491
Lines 35436 3975 -31461
Branches 3861 456 -3405
============================================
- Hits 18144 0 -18144
+ Misses 16393 3975 -12418
+ Partials 899 0 -899
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1617 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `6.99%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 44.20% -7.00%
+ Complexity 3456 3008 -448
============================================
Files 1654 892 -762
Lines 35436 22218 -13218
Branches 3861 2140 -1721
============================================
- Hits 18144 9821 -8323
+ Misses 16393 11553 -4840
+ Partials 899 844 -55
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1207 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `7.09%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 44.10% -7.10%
+ Complexity 3456 3008 -448
============================================
Files 1654 896 -758
Lines 35436 22266 -13170
Branches 3861 2144 -1717
============================================
- Hits 18144 9821 -8323
+ Misses 16393 11601 -4792
+ Partials 899 844 -55
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1205 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `4.94%`.
> The diff coverage is `44.82%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 46.25% -4.95%
+ Complexity 3456 2517 -939
============================================
Files 1654 1655 +1
Lines 35436 35515 +79
Branches 3861 3874 +13
============================================
- Hits 18144 16429 -1715
- Misses 16393 18162 +1769
- Partials 899 924 +25
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `50.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.41% <0.00%> (-80.84%)` | `2.00 <0.00> (-12.00)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `51.92% <15.90%> (-27.11%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `75.00% <75.00%> (ø)` | `7.00 <4.00> (+4.00)` | |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `100.00% <100.00%> (+38.46%)` | `4.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `93.10% <100.00%> (ø)` | `30.00 <2.00> (ø)` | |
| ... and [174 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (71919a6) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `9.34%`.
> The diff coverage is `34.48%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 41.85% -9.35%
+ Complexity 3456 2736 -720
============================================
Files 1654 919 -735
Lines 35436 23027 -12409
Branches 3861 2213 -1648
============================================
- Hits 18144 9639 -8505
+ Misses 16393 12676 -3717
+ Partials 899 712 -187
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `87.09% <71.42%> (-0.16%)` | `14.00 <0.00> (ø)` | |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1222 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (71919a6) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `9.96%`.
> The diff coverage is `34.48%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 41.24% -9.97%
+ Complexity 3456 2691 -765
============================================
Files 1654 919 -735
Lines 35436 22999 -12437
Branches 3861 2208 -1653
============================================
- Hits 18144 9485 -8659
+ Misses 16393 12812 -3581
+ Partials 899 702 -197
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `87.09% <71.42%> (-0.16%)` | `14.00 <0.00> (ø)` | |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1225 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (71919a6) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `51.20%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 0.00% -51.21%
============================================
Files 1654 164 -1490
Lines 35436 3984 -31452
Branches 3861 457 -3404
============================================
- Hits 18144 0 -18144
+ Misses 16393 3984 -12409
+ Partials 899 0 -899
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1617 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (71919a6) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `12.17%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 39.02% -12.18%
+ Complexity 3456 2579 -877
=============================================
Files 1654 915 -739
Lines 35436 22851 -12585
Branches 3861 2195 -1666
=============================================
- Hits 18144 8918 -9226
+ Misses 16393 13251 -3142
+ Partials 899 682 -217
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1231 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (71919a6) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `9.36%`.
> The diff coverage is `34.48%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 41.83% -9.37%
+ Complexity 3456 2735 -721
============================================
Files 1654 919 -735
Lines 35436 23027 -12409
Branches 3861 2213 -1648
============================================
- Hits 18144 9633 -8511
+ Misses 16393 12682 -3711
+ Partials 899 712 -187
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `87.09% <71.42%> (-0.16%)` | `14.00 <0.00> (ø)` | |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1222 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `5.43%`.
> The diff coverage is `34.48%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 45.76% -5.44%
+ Complexity 3456 3211 -245
============================================
Files 1654 934 -720
Lines 35436 23212 -12224
Branches 3861 2253 -1608
============================================
- Hits 18144 10624 -7520
+ Misses 16393 11682 -4711
- Partials 899 906 +7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `87.09% <71.42%> (-0.16%)` | `14.00 <0.00> (ø)` | |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1187 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `7.85%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 43.34% -7.86%
+ Complexity 3456 3008 -448
============================================
Files 1654 915 -739
Lines 35436 22658 -12778
Branches 3861 2198 -1663
============================================
- Hits 18144 9821 -8323
+ Misses 16393 11993 -4400
+ Partials 899 844 -55
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1206 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `3.18%`.
> The diff coverage is `44.82%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 48.01% -3.19%
+ Complexity 3456 2661 -795
============================================
Files 1654 1655 +1
Lines 35436 35527 +91
Branches 3861 3874 +13
============================================
- Hits 18144 17058 -1086
- Misses 16393 17548 +1155
- Partials 899 921 +22
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `50.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.41% <0.00%> (-80.84%)` | `2.00 <0.00> (-12.00)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `51.92% <15.90%> (-27.11%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `75.00% <75.00%> (ø)` | `7.00 <4.00> (+4.00)` | |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `100.00% <100.00%> (+38.46%)` | `4.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `93.10% <100.00%> (ø)` | `30.00 <2.00> (ø)` | |
| ... and [145 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `5.12%`.
> The diff coverage is `34.48%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 46.07% -5.13%
+ Complexity 3456 3159 -297
============================================
Files 1654 915 -739
Lines 35436 22674 -12762
Branches 3861 2200 -1661
============================================
- Hits 18144 10447 -7697
+ Misses 16393 11324 -5069
- Partials 899 903 +4
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `87.09% <71.42%> (-0.16%)` | `14.00 <0.00> (ø)` | |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1197 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `7.31%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 43.89% -7.32%
+ Complexity 3456 2469 -987
============================================
Files 1654 755 -899
Lines 35436 19113 -16323
Branches 3861 1777 -2084
============================================
- Hits 18144 8389 -9755
+ Misses 16393 10092 -6301
+ Partials 899 632 -267
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1254 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `5.50%`.
> The diff coverage is `34.48%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 45.69% -5.51%
+ Complexity 3456 3203 -253
============================================
Files 1654 934 -720
Lines 35436 23212 -12224
Branches 3861 2253 -1608
============================================
- Hits 18144 10607 -7537
+ Misses 16393 11698 -4695
- Partials 899 907 +8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `87.09% <71.42%> (-0.16%)` | `14.00 <0.00> (ø)` | |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1187 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `5.24%`.
> The diff coverage is `34.48%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 45.95% -5.25%
+ Complexity 3456 3159 -297
============================================
Files 1654 917 -737
Lines 35436 22733 -12703
Branches 3861 2207 -1654
============================================
- Hits 18144 10447 -7697
+ Misses 16393 11383 -5010
- Partials 899 903 +4
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `87.09% <71.42%> (-0.16%)` | `14.00 <0.00> (ø)` | |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1197 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (16924b9) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `51.20%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 0.00% -51.21%
============================================
Files 1654 164 -1490
Lines 35436 3984 -31452
Branches 3861 457 -3404
============================================
- Hits 18144 0 -18144
+ Misses 16393 3984 -12409
+ Partials 899 0 -899
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/plugin/PluginSelector.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblNlbGVjdG9yLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1617 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `20.58%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 30.61% -20.59%
+ Complexity 3456 1768 -1688
=============================================
Files 1654 738 -916
Lines 35436 18459 -16977
Branches 3861 1692 -2169
=============================================
- Hits 18144 5651 -12493
+ Misses 16393 12413 -3980
+ Partials 899 395 -504
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1319 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `6.98%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 44.21% -6.99%
+ Complexity 3456 3008 -448
============================================
Files 1654 891 -763
Lines 35436 22212 -13224
Branches 3861 2140 -1721
============================================
- Hits 18144 9821 -8323
+ Misses 16393 11547 -4846
+ Partials 899 844 -55
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1207 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#discussion_r524329616
##########
File path: docs/en/concepts-and-designs/scope-definitions.md
##########
@@ -29,6 +29,7 @@ Calculate the metrics data from each request of the service.
| responseCode | Represent the response code of HTTP response, if this request is the HTTP call | | int|
| type | Represent the type of each request. Such as: Database, HTTP, RPC, gRPC. | | enum |
| tags | Represent the labels of each request and each value is made up with the `TagKey:TagValue` in the segment. | | `List<String>` |
+| sideCar.internalErrorCode | Represent the sidecar/proxy internal error code, the value bases on the implementation. | | string|
Review comment:
In the Istio concept, yes, I agree. But note here, we are adding a description for a service. If this is a gateway, as you mentioned, the service itself is the gateway, rather than this.
Also, for the gateway case, actually, there is no point to indicate whether sidecar issue or not, all errors are gateway's issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `4.94%`.
> The diff coverage is `44.82%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 46.26% -4.95%
+ Complexity 3456 2517 -939
============================================
Files 1654 1655 +1
Lines 35436 35514 +78
Branches 3861 3874 +13
============================================
- Hits 18144 16429 -1715
- Misses 16393 18161 +1768
- Partials 899 924 +25
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `50.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.41% <0.00%> (-80.84%)` | `2.00 <0.00> (-12.00)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `51.92% <15.90%> (-27.11%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `75.00% <75.00%> (ø)` | `7.00 <4.00> (+4.00)` | |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `100.00% <100.00%> (+38.46%)` | `4.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `93.10% <100.00%> (ø)` | `30.00 <2.00> (ø)` | |
| ... and [173 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `5.26%`.
> The diff coverage is `34.48%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 45.93% -5.27%
+ Complexity 3456 3151 -305
============================================
Files 1654 915 -739
Lines 35436 22674 -12762
Branches 3861 2200 -1661
============================================
- Hits 18144 10416 -7728
+ Misses 16393 11362 -5031
+ Partials 899 896 -3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `87.09% <71.42%> (-0.16%)` | `14.00 <0.00> (ø)` | |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1197 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (71919a6) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `11.19%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 40.00% -11.20%
+ Complexity 3456 2637 -819
=============================================
Files 1654 915 -739
Lines 35436 22851 -12585
Branches 3861 2195 -1666
=============================================
- Hits 18144 9142 -9002
+ Misses 16393 13027 -3366
+ Partials 899 682 -217
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1226 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (16924b9) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `12.38%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 38.81% -12.39%
+ Complexity 3456 2697 -759
=============================================
Files 1654 893 -761
Lines 35436 22161 -13275
Branches 3861 2135 -1726
=============================================
- Hits 18144 8602 -9542
+ Misses 16393 12819 -3574
+ Partials 899 740 -159
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1233 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `15.17%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 36.02% -15.18%
+ Complexity 3456 2084 -1372
=============================================
Files 1654 755 -899
Lines 35436 19076 -16360
Branches 3861 1772 -2089
=============================================
- Hits 18144 6873 -11271
+ Misses 16393 11680 -4713
+ Partials 899 523 -376
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1280 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `6.96%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 44.23% -6.97%
+ Complexity 3456 3008 -448
============================================
Files 1654 890 -764
Lines 35436 22201 -13235
Branches 3861 2140 -1721
============================================
- Hits 18144 9821 -8323
+ Misses 16393 11536 -4857
+ Partials 899 844 -55
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1207 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (16924b9) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `12.43%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 38.76% -12.44%
+ Complexity 3456 2697 -759
=============================================
Files 1654 895 -759
Lines 35436 22189 -13247
Branches 3861 2137 -1724
=============================================
- Hits 18144 8602 -9542
+ Misses 16393 12847 -3546
+ Partials 899 740 -159
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1233 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `10.82%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 40.37% -10.83%
+ Complexity 3456 2789 -667
=============================================
Files 1654 881 -773
Lines 35436 21968 -13468
Branches 3861 2104 -1757
=============================================
- Hits 18144 8870 -9274
+ Misses 16393 12336 -4057
+ Partials 899 762 -137
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1229 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `6.55%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 44.65% -6.56%
+ Complexity 3456 3008 -448
============================================
Files 1654 881 -773
Lines 35436 21995 -13441
Branches 3861 2119 -1742
============================================
- Hits 18144 9821 -8323
+ Misses 16393 11330 -5063
+ Partials 899 844 -55
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1208 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (16924b9) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `21.40%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 29.79% -21.41%
+ Complexity 3456 2010 -1446
=============================================
Files 1654 886 -768
Lines 35436 22083 -13353
Branches 3861 2129 -1732
=============================================
- Hits 18144 6580 -11564
+ Misses 16393 15006 -1387
+ Partials 899 497 -402
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1288 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (93e83d0) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `6.55%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 44.64% -6.56%
+ Complexity 3456 3006 -450
============================================
Files 1654 881 -773
Lines 35436 21989 -13447
Branches 3861 2106 -1755
============================================
- Hits 18144 9818 -8326
+ Misses 16393 11326 -5067
+ Partials 899 845 -54
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1210 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (71919a6) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `9.45%`.
> The diff coverage is `34.48%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 41.74% -9.46%
+ Complexity 3456 2727 -729
============================================
Files 1654 919 -735
Lines 35436 23027 -12409
Branches 3861 2213 -1648
============================================
- Hits 18144 9612 -8532
+ Misses 16393 12704 -3689
+ Partials 899 711 -188
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `87.09% <71.42%> (-0.16%)` | `14.00 <0.00> (ø)` | |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1223 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (d97025b) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `13.46%`.
> The diff coverage is `28.73%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
=============================================
- Coverage 51.20% 37.74% -13.47%
+ Complexity 3456 2517 -939
=============================================
Files 1654 907 -747
Lines 35436 22721 -12715
Branches 3861 2188 -1673
=============================================
- Hits 18144 8575 -9569
+ Misses 16393 13514 -2879
+ Partials 899 632 -267
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.45% <0.00%> (-80.80%)` | `2.00 <0.00> (-12.00)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1234 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...93e83d0](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (71919a6) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `9.84%`.
> The diff coverage is `34.48%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 41.35% -9.85%
+ Complexity 3456 2697 -759
============================================
Files 1654 919 -735
Lines 35436 22999 -12437
Branches 3861 2208 -1653
============================================
- Hits 18144 9512 -8632
+ Misses 16393 12782 -3611
+ Partials 899 705 -194
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `87.09% <71.42%> (-0.16%)` | `14.00 <0.00> (ø)` | |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1225 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#issuecomment-727857729
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=h1) Report
> Merging [#5849](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=desc) (71919a6) into [master](https://codecov.io/gh/apache/skywalking/commit/48479b74df22a71e7a894e600a94df593a583187?el=desc) (48479b7) will **decrease** coverage by `8.63%`.
> The diff coverage is `34.48%`.
[](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5849 +/- ##
============================================
- Coverage 51.20% 42.57% -8.64%
+ Complexity 3456 2774 -682
============================================
Files 1654 919 -735
Lines 35436 23030 -12406
Branches 3861 2213 -1648
============================================
- Hits 18144 9804 -8340
+ Misses 16393 12513 -3880
+ Partials 899 713 -186
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../skywalking/oal/rt/parser/ConditionExpression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9Db25kaXRpb25FeHByZXNzaW9uLmphdmE=) | `57.14% <0.00%> (-4.40%)` | `4.00 <0.00> (ø)` | |
| [...rg/apache/skywalking/oal/rt/parser/Expression.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FeHByZXNzaW9uLmphdmE=) | `100.00% <ø> (ø)` | `3.00 <0.00> (ø)` | |
| [...server/receiver/envoy/als/AbstractALSAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0Fic3RyYWN0QUxTQW5hbHl6ZXIuamF2YQ==) | `0.00% <ø> (-50.00%)` | `0.00 <0.00> (ø)` | |
| [...er/receiver/envoy/als/LogEntry2MetricsAdapter.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0xvZ0VudHJ5Mk1ldHJpY3NBZGFwdGVyLmphdmE=) | `0.00% <0.00%> (-79.04%)` | `0.00 <0.00> (ø)` | |
| [...apache/skywalking/oal/rt/util/ClassMethodUtil.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3V0aWwvQ2xhc3NNZXRob2RVdGlsLmphdmE=) | `55.00% <50.00%> (-20.00%)` | `7.00 <4.00> (+4.00)` | :arrow_down: |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `87.09% <71.42%> (-0.16%)` | `14.00 <0.00> (ø)` | |
| [...pache/skywalking/oal/rt/parser/AnalysisResult.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9BbmFseXNpc1Jlc3VsdC5qYXZh) | `74.57% <100.00%> (+0.43%)` | `19.00 <0.00> (ø)` | |
| [.../apache/skywalking/oal/rt/parser/DeepAnalysis.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9EZWVwQW5hbHlzaXMuamF2YQ==) | `83.09% <100.00%> (ø)` | `14.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/EntryMethod.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9FbnRyeU1ldGhvZC5qYXZh) | `92.00% <100.00%> (ø)` | `10.00 <0.00> (ø)` | |
| [...g/apache/skywalking/oal/rt/parser/OALListener.java](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9PQUxMaXN0ZW5lci5qYXZh) | `77.01% <100.00%> (-16.10%)` | `30.00 <2.00> (ø)` | |
| ... and [1216 more](https://codecov.io/gh/apache/skywalking/pull/5849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=footer). Last update [48479b7...16924b9](https://codecov.io/gh/apache/skywalking/pull/5849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on a change in pull request #5849: Support `sideCar.internalErrorCode` in the sources
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #5849:
URL: https://github.com/apache/skywalking/pull/5849#discussion_r524350904
##########
File path: docs/en/concepts-and-designs/scope-definitions.md
##########
@@ -29,6 +29,7 @@ Calculate the metrics data from each request of the service.
| responseCode | Represent the response code of HTTP response, if this request is the HTTP call | | int|
| type | Represent the type of each request. Such as: Database, HTTP, RPC, gRPC. | | enum |
| tags | Represent the labels of each request and each value is made up with the `TagKey:TagValue` in the segment. | | `List<String>` |
+| sideCar.internalErrorCode | Represent the sidecar/proxy internal error code, the value bases on the implementation. | | string|
Review comment:
> Also, for the gateway case, actually, there is no point to indicate whether sidecar issue or not, all errors are gateway's issue.
Definitely, a gateway is abstracted to service, but it still needs `sidecar.xxxx` to represent this dimension. It looks a little tricky, especially, the remarks emphasize `the sidecar/proxy internal error code`. if that, `the sidecar/gateway proxy internal error code` makes more sense to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org