You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/03/15 05:39:35 UTC

[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #7028: Feature: Adding warning message for sqllab save query

mistercrunch commented on a change in pull request #7028: Feature: Adding warning message for sqllab save query
URL: https://github.com/apache/incubator-superset/pull/7028#discussion_r265855052
 
 

 ##########
 File path: superset/assets/src/SqlLab/components/SaveQuery.jsx
 ##########
 @@ -108,6 +110,18 @@ class SaveQuery extends React.PureComponent {
           </Col>
         </Row>
         <br />
+        {this.props.saveQueryWarning && (
+          <div>
+            <Row>
 
 Review comment:
   Are the `div->Row->Col` wrappers useful here? Wondering if you could just go straight to a `<small>` 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org