You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/04 12:37:26 UTC

[GitHub] [spark] srowen edited a comment on pull request #29647: [SPARK-32764][SQL] -0.0 should be equal to 0.0

srowen edited a comment on pull request #29647:
URL: https://github.com/apache/spark/pull/29647#issuecomment-687116478


   `0.0 > -0.0` should be false in SQL? then I agree. That's the answer in the JVM languages too.
   
   However that's not true in other contexts, like sorting things, where you do want a total ordering on doubles. I think we had to confront that a while ago in dealing with Scala 2.13 or something. If this doesn't affect sorts then I think that's fine (and it doesn't seem to)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org