You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2021/12/03 22:06:32 UTC
[Impala-ASF-CR] IMPALA-11047: Disable overlap predicate if not reading statistic.
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18069
Change subject: IMPALA-11047: Disable overlap predicate if not reading statistic.
......................................................................
IMPALA-11047: Disable overlap predicate if not reading statistic.
Preconditions.checkNotNull(statsTuple_) will fail in HdfsScanNode.java
if user explicitly set PARQUET_READ_STATISTICS / ORC_READ_STATISTICS to
false (depending on the underlying file format). This patch fixes the
issue by checking if statsTuple_ has been initialized before calling
initOverlapPredicate() in RuntimeFilterGenerator.java.
Testing:
- Add test case in overlap_min_max_filters.test where we set
PARQUET_READ_STATISTICS and ORC_READ_STATISTICS to false.
- Pass all testcases in
TestOverlapMinMaxFilters::test_overlap_min_max_filters.
Change-Id: I1e9aad80a934f7104bab015d00edb3061c5fd60d
---
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
M fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java
M testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters.test
3 files changed, 46 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/18069/1
--
To view, visit http://gerrit.cloudera.org:8080/18069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e9aad80a934f7104bab015d00edb3061c5fd60d
Gerrit-Change-Number: 18069
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-11047: Disable overlap predicate if not reading statistic.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18069 )
Change subject: IMPALA-11047: Disable overlap predicate if not reading statistic.
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9873/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e9aad80a934f7104bab015d00edb3061c5fd60d
Gerrit-Change-Number: 18069
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Dec 2021 22:29:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11047: Disable overlap predicate if not reading statistic.
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has abandoned this change. ( http://gerrit.cloudera.org:8080/18069 )
Change subject: IMPALA-11047: Disable overlap predicate if not reading statistic.
......................................................................
Abandoned
Abandoning in favor of https://gerrit.cloudera.org/c/18071
--
To view, visit http://gerrit.cloudera.org:8080/18069
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I1e9aad80a934f7104bab015d00edb3061c5fd60d
Gerrit-Change-Number: 18069
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>