You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/04 23:14:20 UTC

[GitHub] [superset] EvilDrW opened a new issue #17927: [SIP-77] Traversing Hierarchical Data ("Drill Down")

EvilDrW opened a new issue #17927:
URL: https://github.com/apache/superset/issues/17927


   ## [SIP-77] Proposal for Traversing Hierarchical Data ("Drill Down")
   
   ### Motivation
   
   Many data sets have a natural hierarchy.  When viewing these data sets, a common user request is to apply filters for each tier of the hierarchy iteratively.  While superset provides accommodations to define these filters, the available methods are far from intuitive.  A more appropriate user interaction would be:
   1. Display only values for the highest tier in the hierarchy
   2. User clicks one of the displayed values
   3. Superset filters based on the selected value
   4. Return to #1, showing only values for the next tier
   
   ### Proposed Change
   
   The proposed feature will provide an "enable drill down" check box on the control panels for all compatible chart types.  Examples of possible compatible charts include pie, bar, tree maps, etc.  When selected, the feature will use the column names in the "group by" field, in the order that they appear, as the data hierarchy.  The iteratively selected filters will, as usual, be applied across all charts in the current filter scope (tab, dashboard page, etc.).  The current state of the "drill down" will be tracked in the chart's OwnState object, as necessary.
   
   For a demonstration of the proposed change on a pie chart, see the videos on https://github.com/apache/superset/pull/14688
   
   ### New or Changed Public Interfaces
   
   The only change to the interfaces, as envisioned, is the addition of the "enable drill down" checkbox to appropriate charts' control panels.
   
   ### New dependencies
   
   n/a
   
   ### Migration Plan and Compatibility
   
   n/a
   
   ### Rejected Alternatives
   
   n/a
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] villebro commented on issue #17927: [SIP-77] Traversing Hierarchical Data ("Drill Down")

Posted by GitBox <gi...@apache.org>.
villebro commented on issue #17927:
URL: https://github.com/apache/superset/issues/17927#issuecomment-1005704365


   I would also love seeing drill down/through functionality added to Superset! I think there are roughly two ways forward here:
   1) adding drill down in the chart layer, much like has been done in #14688
   2) adding support for hierarchical dimensions to the semantic layer.
   
   Both probably have their pros/cons:
   - Adding drill down to a single chart is fairly straight forward and wouldn't require a lot of changes to the rest of the application. On the downside it's slightly hacky and might introduce some design debt.
   - Adding semantics for defining hierarchical dimensions would make it possible to introduce drill downs into any chart (including native filters), but on the downside it's a fair bit of work and could take long to implement.
   
   As we're getting ready to kick off work for Superset 2.0, I'd personally vote for the second option, as I feel having full drill down support would be a very valuable (and cool!) feature.
   
   @betodealmeida , has any consideration been given to adding hierarchical dimension semantics to the new dataset models?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] shadowDy commented on issue #17927: [SIP-77] Traversing Hierarchical Data ("Drill Down")

Posted by GitBox <gi...@apache.org>.
shadowDy commented on issue #17927:
URL: https://github.com/apache/superset/issues/17927#issuecomment-1012054187


   When does superset plan to support drill down?
   thanks~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido commented on issue #17927: [SIP-77] Traversing Hierarchical Data ("Drill Down")

Posted by GitBox <gi...@apache.org>.
geido commented on issue #17927:
URL: https://github.com/apache/superset/issues/17927#issuecomment-1005879934


   First of all, thanks @EvilDrW and @zhaoyongjie for moving this forward. I believe this functionality is a must have and would love to see it in Superset.
   
   However, I also feel we should go for the most scalable solution rather than implementing the drill down on a chart by chart basis. 
   
   > Adding semantics for defining hierarchical dimensions would make it possible to introduce drill downs into any chart (including native filters), but on the downside it's a fair bit of work and could take long to implement.
   
   > As we're getting ready to kick off work for Superset 2.0, I'd personally vote for the second option, as I feel having full drill down support would be a very valuable (and cool!) feature.
   
   I agree with what @villebro is proposing. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] EvilDrW commented on issue #17927: [SIP-77] Traversing Hierarchical Data ("Drill Down")

Posted by GitBox <gi...@apache.org>.
EvilDrW commented on issue #17927:
URL: https://github.com/apache/superset/issues/17927#issuecomment-1018077626


   @villebro @geido @betodealmeida: thanks for the feedback.
   I'm sure that what you're requesting is the right way forward for the project, but it is quite far beyond both my interest and skill level.  I'll be interested to see how this progresses, but it will have to be someone other than me who implements it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] Vygo edited a comment on issue #17927: [SIP-77] Traversing Hierarchical Data ("Drill Down")

Posted by GitBox <gi...@apache.org>.
Vygo edited a comment on issue #17927:
URL: https://github.com/apache/superset/issues/17927#issuecomment-1006033523


   @geido @villebro Thank you for your feedback. 
   Is there an estimate of when this would do with the 2nd approach? Is the target release date for Superset 2.0?
   
   @EvilDrW is an engineer here at Stylo. As a company that actively uses superset this functionality is crucial for us and I would love if we could get this in as an MVP, while the team is working on the most scalable/long-term solution. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] srinify commented on issue #17927: [SIP-80] Traversing Hierarchical Data ("Drill Down")

Posted by GitBox <gi...@apache.org>.
srinify commented on issue #17927:
URL: https://github.com/apache/superset/issues/17927#issuecomment-1030411955


   Hey there, I renamed this to SIP-80 since there's already a SIP-77: https://github.com/apache/superset/issues/17296


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] crazamahdi commented on issue #17927: [SIP-80] Traversing Hierarchical Data ("Drill Down")

Posted by GitBox <gi...@apache.org>.
crazamahdi commented on issue #17927:
URL: https://github.com/apache/superset/issues/17927#issuecomment-1057065288


   Is the drill down feature out? @EvilDrW I am not able to see enable drilldown feature in my superset can anyone please help me implementing that feature in superset (if the feature is out)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] betodealmeida commented on issue #17927: [SIP-77] Traversing Hierarchical Data ("Drill Down")

Posted by GitBox <gi...@apache.org>.
betodealmeida commented on issue #17927:
URL: https://github.com/apache/superset/issues/17927#issuecomment-1007600171


   > @betodealmeida , has any consideration been given to adding hierarchical dimension semantics to the new dataset models?
   
   @villebro We have not, but we definitely should. It could be as simple as defining the parent column in the dataset, eg, in `city` we'd set `state` as the parent dimension, in `state` we'd set `country`, and so on.
   
   @EvilDrW I have questions about additive metrics. When you're at the country level, how do you compute the metrics, do you run a query with only `country` in the group by or do you run the full group by (`country`, `state`, `city`) and add the values? If the latter we should think how we're going to handle non-additive metrics like `COUNT DISTINCT` — this is another area where the semantic layer can help.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] Vygo commented on issue #17927: [SIP-77] Traversing Hierarchical Data ("Drill Down")

Posted by GitBox <gi...@apache.org>.
Vygo commented on issue #17927:
URL: https://github.com/apache/superset/issues/17927#issuecomment-1006033523


   @geido @villebro Thank you for your feedback. 
   Is there an estimate of when this would do with the 2nd approach? Is the target release date for Superset 2.0?
   
   Keith is an engineer here at Stylo. As a company that actively uses superset this functionality is crucial for us and I would love if we could get this in as an MVP, while the team is working on the most scalable/long-term solution. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] betodealmeida commented on issue #17927: [SIP-77] Traversing Hierarchical Data ("Drill Down")

Posted by GitBox <gi...@apache.org>.
betodealmeida commented on issue #17927:
URL: https://github.com/apache/superset/issues/17927#issuecomment-1007600171


   > @betodealmeida , has any consideration been given to adding hierarchical dimension semantics to the new dataset models?
   
   @villebro We have not, but we definitely should. It could be as simple as defining the parent column in the dataset, eg, in `city` we'd set `state` as the parent dimension, in `state` we'd set `country`, and so on.
   
   @EvilDrW I have questions about additive metrics. When you're at the country level, how do you compute the metrics, do you run a query with only `country` in the group by or do you run the full group by (`country`, `state`, `city`) and add the values? If the latter we should think how we're going to handle non-additive metrics like `COUNT DISTINCT` — this is another area where the semantic layer can help.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org