[GitHub] [pulsar] lhotari commented on pull request #13252: [CI] Fix Tune Runner VM memory.swappiness no such file or directory

[GitBox <gi...@apache.org>]

lhotari commented on pull request #13252:
URL: https://github.com/apache/pulsar/pull/13252#issuecomment-1075978375


   This was the wrong solution to the problem. The change makes the shell script basically a no-op.
   
   The correct solution to the problem would have been to set `shopt -s nullglob`.
   
   Here's an example from the Pulsar CI refactoring:
   ```bash
               (
                 shopt -s nullglob
                 # Set swappiness to 1 for all cgroups and sub-groups
                 for swappiness_file in /sys/fs/cgroup/memory/*/memory.swappiness /sys/fs/cgroup/memory/*/*/memory.swappiness; do
                   echo 1 | sudo tee $swappiness_file > /dev/null
                 done
               )
   ```
   
   I'll be including this fix as part of the Pulsar CI refactoring that I have [announced on the dev mailing list](https://lists.apache.org/thread/2oyk217f88bmsod98vsb6c5gspvxvpo4).
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org