You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "AMashenkov (via GitHub)" <gi...@apache.org> on 2023/08/24 07:45:21 UTC
[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2476: IGNITE-19788 Sql. Change QueryBatchMessage serialization
AMashenkov commented on code in PR #2476:
URL: https://github.com/apache/ignite-3/pull/2476#discussion_r1303935784
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/RowHandler.java:
##########
@@ -17,36 +17,75 @@
package org.apache.ignite.internal.sql.engine.exec;
+import java.nio.ByteBuffer;
import org.apache.ignite.internal.sql.engine.exec.row.RowSchema;
import org.jetbrains.annotations.Nullable;
/**
* Universal accessor and mutator for rows. It also has factory methods.
*/
public interface RowHandler<RowT> {
+ /**
+ * Extract appropriate field.
+ *
+ * @param field position.
Review Comment:
```suggestion
* @param field Field position.
```
Do you mean field index or offset in byte array, if RowT is byte array?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org