[GitHub] hbasejanitor commented on a change in pull request #3: HBASE-21002 make an assembly for hbase-connectors

[GitBox <gi...@apache.org>]

hbasejanitor commented on a change in pull request #3: HBASE-21002 make an assembly for hbase-connectors
URL: https://github.com/apache/hbase-connectors/pull/3#discussion_r218788287
 
 

 ##########
 File path: kafka/hbase-kafka-proxy/src/main/java/org/apache/hadoop/hbase/kafka/KafkaProxy.java
 ##########
 @@ -154,19 +150,28 @@ public static void main(String[] args) throws Exception {
     options.addOption("e", "enablepeer", false,
         "enable peer on startup (defaults to false)");
 
-
     LOG.info("STARTING executorService " + HRegionServer.class.getSimpleName());
     VersionInfo.logVersion();
 
     Configuration conf = HBaseConfiguration.create();
     CommandLine commandLine = null;
+
+    Configuration commandLineConf = new Configuration();
 
 Review comment:
   Hi Stack, I'm doing it that way so the user can pass -Dconfkey=confValue on the command line.  What I do is create an empty conf object, then use GenericOptionsParser to pick out all the -D arguments.  I then feed those values into the region server that I start.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services