You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "kevinjqliu (via GitHub)" <gi...@apache.org> on 2025/06/17 15:31:26 UTC
[PR] [infra] publish rc to pypi as part of release process [iceberg-rust]
kevinjqliu opened a new pull request, #1449:
URL: https://github.com/apache/iceberg-rust/pull/1449
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
- Closes #1409.
## What changes are included in this PR?
<!--
Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates.
-->
## Are these changes tested?
<!--
Specify what test covers (unit test, integration test, etc.).
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
Yes, tested against personal fork.
Tested
- push RC tag, i.e. `v0.6.0-rc.1`
- push release tag, i.e. `v0.6.0`
- push invalid tag, i.e. `should-not-trigger`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] [infra] publish rc to pypi as part of release process [iceberg-rust]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #1449:
URL: https://github.com/apache/iceberg-rust/pull/1449#discussion_r2152578305
##########
.github/workflows/publish.yml:
##########
@@ -20,7 +20,9 @@ name: Publish
on:
push:
tags:
- - "*"
+ # Trigger this workflow when tag follows the versioning format: v<major>.<minor>.<patch>-rc.<release_candidate>
Review Comment:
inspiration from pyiceberg
https://github.com/apache/iceberg-python/blob/483d9475cd729bdd9bb70fd9d1d7b6ff96d98cc1/.github/workflows/python-release.yml#L22-L27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] [infra] publish rc to pypi as part of release process [iceberg-rust]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #1449:
URL: https://github.com/apache/iceberg-rust/pull/1449#discussion_r2162411590
##########
.github/workflows/publish.yml:
##########
@@ -20,7 +20,10 @@ name: Publish
on:
push:
tags:
- - "*"
+ # Trigger this workflow when tag follows the versioning format: v<major>.<minor>.<patch> OR v<major>.<minor>.<patch>-rc.<release_candidate>
+ # Example valid tags: v0.4.0, v0.4.0-rc.1
+ - "v[0-9]+.[0-9]+.[0-9]+"
+ - "v[0-9]+.[0-9]+.[0-9]+-rc.[0-9]+"
Review Comment:
I consider myself a bit of a regex connoisseur.
```suggestion
- "v\d+.\d+.\d+"
- "v\d+.\d+.\d+-rc.\d+"
```
<img width="1139" alt="image" src="https://github.com/user-attachments/assets/967eec62-410b-410a-a20e-f4a2f5bb4aca" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] [infra] publish rc to pypi as part of release process [iceberg-rust]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #1449:
URL: https://github.com/apache/iceberg-rust/pull/1449#discussion_r2162430124
##########
.github/workflows/publish.yml:
##########
@@ -20,7 +20,10 @@ name: Publish
on:
push:
tags:
- - "*"
+ # Trigger this workflow when tag follows the versioning format: v<major>.<minor>.<patch> OR v<major>.<minor>.<patch>-rc.<release_candidate>
+ # Example valid tags: v0.4.0, v0.4.0-rc.1
+ - "v[0-9]+.[0-9]+.[0-9]+"
+ - "v[0-9]+.[0-9]+.[0-9]+-rc.[0-9]+"
Review Comment:
fun fact! the `on.push.tags` syntax here doesnt support regex, its a "filter pattern"
from https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#onpushbranchestagsbranches-ignoretags-ignore,
```
The branches, branches-ignore, tags, and tags-ignore keywords accept glob patterns that use characters like *, **, +, ?, ! and others to match more than one branch or tag name. If a name contains any of these characters and you want a literal match, you need to escape each of these special characters with \. For more information about glob patterns, see the [Workflow syntax for GitHub Actions](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet).
```
https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] [infra] publish rc to pypi as part of release process [iceberg-rust]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #1449:
URL: https://github.com/apache/iceberg-rust/pull/1449#discussion_r2161927117
##########
.github/workflows/release_python.yml:
##########
@@ -28,7 +28,7 @@ env:
rust_msrv: "1.85"
concurrency:
- group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
+ group: ${{ github.workflow }}-${{ github.event.workflow_run.head_branch }}-${{ github.event_name }}
Review Comment:
after changing `github.ref` -> `github.event.workflow_run.head_branch` in #1444, this was missed.
just a minor improvement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] [infra] publish rc to pypi as part of release process [iceberg-rust]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #1449:
URL: https://github.com/apache/iceberg-rust/pull/1449#discussion_r2162430124
##########
.github/workflows/publish.yml:
##########
@@ -20,7 +20,10 @@ name: Publish
on:
push:
tags:
- - "*"
+ # Trigger this workflow when tag follows the versioning format: v<major>.<minor>.<patch> OR v<major>.<minor>.<patch>-rc.<release_candidate>
+ # Example valid tags: v0.4.0, v0.4.0-rc.1
+ - "v[0-9]+.[0-9]+.[0-9]+"
+ - "v[0-9]+.[0-9]+.[0-9]+-rc.[0-9]+"
Review Comment:
fun fact! the on.push.tags syntax here doesnt support regex.
from https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#onpushbranchestagsbranches-ignoretags-ignore,
```
The branches, branches-ignore, tags, and tags-ignore keywords accept glob patterns that use characters like *, **, +, ?, ! and others to match more than one branch or tag name. If a name contains any of these characters and you want a literal match, you need to escape each of these special characters with \. For more information about glob patterns, see the [Workflow syntax for GitHub Actions](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet).
```
https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet
##########
.github/workflows/publish.yml:
##########
@@ -20,7 +20,10 @@ name: Publish
on:
push:
tags:
- - "*"
+ # Trigger this workflow when tag follows the versioning format: v<major>.<minor>.<patch> OR v<major>.<minor>.<patch>-rc.<release_candidate>
+ # Example valid tags: v0.4.0, v0.4.0-rc.1
+ - "v[0-9]+.[0-9]+.[0-9]+"
+ - "v[0-9]+.[0-9]+.[0-9]+-rc.[0-9]+"
Review Comment:
fun fact! the `on.push.tags` syntax here doesnt support regex.
from https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#onpushbranchestagsbranches-ignoretags-ignore,
```
The branches, branches-ignore, tags, and tags-ignore keywords accept glob patterns that use characters like *, **, +, ?, ! and others to match more than one branch or tag name. If a name contains any of these characters and you want a literal match, you need to escape each of these special characters with \. For more information about glob patterns, see the [Workflow syntax for GitHub Actions](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet).
```
https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] [infra] publish rc to pypi as part of release process [iceberg-rust]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu merged PR #1449:
URL: https://github.com/apache/iceberg-rust/pull/1449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] [infra] publish rc to pypi as part of release process [iceberg-rust]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #1449:
URL: https://github.com/apache/iceberg-rust/pull/1449#issuecomment-2996984574
Most important thing here is that for a RC tag push, i.e. `v0.6.0-rc.1`, the generate pypi artifacts is set to a pre-release version.
For example, `wheels-sdist` from [test run](https://github.com/kevinjqliu/iceberg-rust/actions/runs/15815944806) is set to `Version: 0.6.0rc1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org