You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/08 10:32:54 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #10488: Add Kerberos Auth for Presto

potiuk commented on a change in pull request #10488:
URL: https://github.com/apache/airflow/pull/10488#discussion_r501616475



##########
File path: scripts/ci/docker-compose/integration-kerberos.yml
##########
@@ -17,16 +17,55 @@
 ---
 version: "2.2"
 services:
-  kerberos:
-    image: apache/airflow:krb5-kdc-server-2020.08.28
-    hostname: kerberos
+  kdc-server-example-com:
+    build:
+      context: ..
+      dockerfile: ./dockerfiles/krb5-kdc-server/Dockerfile
+    image: krb5-kdc-server-example-com

Review comment:
       One thing I would like to change here - rather than building the kerberos image, we should publish it in airflow repo. This way we will have much faster tests. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org