You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/12/14 13:24:06 UTC

[GitHub] nvazquez commented on a change in pull request #3095: Prevent corner case for infinite PrepareForMaintenance

nvazquez commented on a change in pull request #3095: Prevent corner case for infinite PrepareForMaintenance
URL: https://github.com/apache/cloudstack/pull/3095#discussion_r241752783
 
 

 ##########
 File path: server/src/com/cloud/resource/ResourceManagerImpl.java
 ##########
 @@ -1350,7 +1364,23 @@ protected boolean isHostInMaintenance(HostVO host, List<VMInstanceVO> runningVms
             return CollectionUtils.isEmpty(failedMigrations) ?
                     setHostIntoMaintenance(host) :
                     setHostIntoErrorInMaintenance(host, failedMigrations);
+        } else if (retryHostMaintenance.containsKey(host.getId())) {
 
 Review comment:
   You're right, I'll refactor it, thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services