You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by AndyClausen <gi...@git.apache.org> on 2017/07/11 12:48:02 UTC

[GitHub] cordova-android pull request #393: Fix for Jira issue CB-12981

GitHub user AndyClausen opened a pull request:

    https://github.com/apache/cordova-android/pull/393

    Fix for Jira issue CB-12981

    https://issues.apache.org/jira/browse/CB-12981
    Using match with regex instead of split and replace
    
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    
    ### What does this PR do?
    
    
    ### What testing has been done on this change?
    
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AndyClausen/cordova-android patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/393.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #393
    
----
commit d22fd2b9ab8cec3619e923d3e0389d0f4577e561
Author: AndyClausen <an...@hotmail.com>
Date:   2017-07-11T12:46:56Z

    Fix for Jira issue CB-12981
    
    https://issues.apache.org/jira/browse/CB-12981
    Using match with regex instead of split and replace

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-android issue #393: Fix for Jira issue CB-12981

Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:

    https://github.com/apache/cordova-android/pull/393
  
    I think if the PR author rebases w/ latest master, they will find that test no longer exists / no longer applicable.
    
    I bet it was Travis VM being too slow / our timeout for the create/compile loop being too low.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org

[GitHub] cordova-android issue #393: Fix for Jira issue CB-12981

Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:

    https://github.com/apache/cordova-android/pull/393
  
    This somehow broke the project creation test.  Can you figure out what happened with your PR that caused this to break?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org