[jira] [Resolved] (HADOOP-10363) Closing of SequenceFile.Reader / SequenceFile.Writer in DistCh should check against null

["Varun Saxena (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-10363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Varun Saxena resolved HADOOP-10363.
-----------------------------------
    Resolution: Not A Problem

Closing this. This issue no longer exists as DistCh now uses try with resources construct. Feel free to reopen if you think otherwise

> Closing of SequenceFile.Reader / SequenceFile.Writer in DistCh should check against null
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-10363
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10363
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>         Attachments: HADOOP-10363.patch
>
>
> Here is related code:
> {code}
>       try {
>         for(in = new SequenceFile.Reader(fs, srcs, job); in.next(key, value); ) {
> ...
>       finally {
>         in.close();
>       }
> {code}
> {code}
>     SequenceFile.Writer opWriter = null;
>     try {
>       opWriter = SequenceFile.createWriter(fs, jobconf, opList, Text.class,
>           FileOperation.class, SequenceFile.CompressionType.NONE);
> ...
>     } finally {
>       opWriter.close();
>     }
> {code}
> If ctor of Reader / Writer throws exception, the close() would be called on null object.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)