[GitHub] [kafka] junrao commented on a change in pull request #11641: MINOR: update the comment for Utils.atomicMoveWithFallback

[GitBox <gi...@apache.org>]

junrao commented on a change in pull request #11641:
URL: https://github.com/apache/kafka/pull/11641#discussion_r778987140



##########
File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java
##########
@@ -924,7 +924,7 @@ public static void atomicMoveWithFallback(Path source, Path target) throws IOExc
      * when a sequence of atomicMoveWithFallback is called for the same directory and we don't want
      * to repeatedly flush the same parent directory.
      *
-     * @throws IOException if both atomic and non-atomic moves fail
+     * @throws IOException if both atomic and non-atomic moves fail, or parent dir flush fails.

Review comment:
       or parent dir flush fails => or parent dir flush needFlushParentDir is true?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org