[GitHub] [iceberg] shardulm94 commented on a diff in pull request #6327: ORC: Fix error when projecting nested indentity partition column

[GitBox <gi...@apache.org>]

shardulm94 commented on code in PR #6327:
URL: https://github.com/apache/iceberg/pull/6327#discussion_r1041512368


##########
api/src/main/java/org/apache/iceberg/types/TypeUtil.java:
##########
@@ -136,7 +136,16 @@ public static Types.StructType selectNot(Types.StructType struct, Set<Integer> f
   }
 
   public static Schema selectNot(Schema schema, Set<Integer> fieldIds) {
-    Set<Integer> projectedIds = getIdsInternal(schema.asStruct(), false);
+    return selectNot(schema, fieldIds, false);
+  }
+
+  public static Schema selectNotPreserveEmptyStructs(Schema schema, Set<Integer> fieldIds) {

Review Comment:
   That makes sense. Since ORC is the only format using this behavior, I now added this code to `OrcSchemaUtil`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org