You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by pasalkarsachin1 <gi...@git.apache.org> on 2017/01/16 19:30:28 UTC
[GitHub] storm pull request #1878: Issue Fixed
GitHub user pasalkarsachin1 opened a pull request:
https://github.com/apache/storm/pull/1878
Issue Fixed
I have just updated code to make sure sequence Fields should remains same even its added in set. In old implementation because of HashSet it was changing. Also added testcase for the same
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pasalkarsachin1/storm STORM-2295
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1878.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1878
----
commit 8d44da9c9a3956fb01b266af4f79e52d2744155d
Author: pasalkarsachin1 <pa...@gmail.com>
Date: 2017-01-16T19:26:14Z
Issue Fixed
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1878: STORM-2295:KafkaSpoutStreamsNamedTopics changing the sequ...
Posted by pasalkarsachin1 <gi...@git.apache.org>.
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1878
@HeartSaVioR
Done. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1878: STORM-2295:Issue Fixed
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1878
@pasalkarsachin1
Please change the PR's title to same as issue's title or at least summary of this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1878: STORM-2295:KafkaSpoutStreamsNamedTopics changing the sequ...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1878
+1 the change looks good to me. Great catch @pasalkarsachin1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1878: STORM-2295:KafkaSpoutStreamsNamedTopics changing the sequ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1878
@pasalkarsachin1
And also please squash the commits into one after fixing license info.
I recommend the title of commit message as `STORM-2295 KafkaSpoutStreamsNamedTopics changing the sequence of fields name while emitting data` and abstracted description to the body.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1878: STORM-2295:KafkaSpoutStreamsNamedTopics changing t...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1878#discussion_r96769287
--- Diff: external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutStreamsNamedTopicsTest.java ---
@@ -0,0 +1,23 @@
+package org.apache.storm.kafka.spout;
--- End diff --
Please add the Apache License
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1878: STORM-2295:KafkaSpoutStreamsNamedTopics changing the sequ...
Posted by pasalkarsachin1 <gi...@git.apache.org>.
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1878
Can someone merge it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1878: STORM-2295:KafkaSpoutStreamsNamedTopics changing the sequ...
Posted by hmcl <gi...@git.apache.org>.
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1878
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1878: STORM-2295:KafkaSpoutStreamsNamedTopics changing the sequ...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1878
@pasalkarsachin1 one of the files missing the License info. Please add that. We can merge it in after that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1878: STORM-2295:KafkaSpoutStreamsNamedTopics changing the sequ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1878
@pasalkarsachin1
PR has been applied to master via ba406c16a27221dc4c1ca7ac3d3c3164cb669bfd and 1.x-branch via f4fdab3a45017dc042eda0c0c65d06a37f6cf904.
(I just cherry-picked 7168710 since it's squashed commit and others are not necessary.)
Could you please close this issue? Thanks in advance!
(Github doesn't recognize auto PR close message which PR is not target to master branch.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1878: STORM-2295:KafkaSpoutStreamsNamedTopics changing the sequ...
Posted by pasalkarsachin1 <gi...@git.apache.org>.
Github user pasalkarsachin1 commented on the issue:
https://github.com/apache/storm/pull/1878
I squashed it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1878: STORM-2295:KafkaSpoutStreamsNamedTopics changing the sequ...
Posted by hmcl <gi...@git.apache.org>.
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1878
I would suggest for title `STORM-2295 KafkaSpoutStreamsNamedTopics should return output fields with predictable ordering`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---