You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "rockwotj (via GitHub)" <gi...@apache.org> on 2026/03/18 20:53:40 UTC

[PR] fix(table): don't always set schema.name-mapping.default [iceberg-go]

rockwotj opened a new pull request, #803:
URL: https://github.com/apache/iceberg-go/pull/803

   It seems Databricks Unity Catalog is unhappy with this, so don't set it
   by default and ask the caller if they are in the sophisticated method of
   supplying their own DataFiles.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] fix(table): don't always set schema.name-mapping.default [iceberg-go]

Posted by "rockwotj (via GitHub)" <gi...@apache.org>.
rockwotj commented on PR #803:
URL: https://github.com/apache/iceberg-go/pull/803#issuecomment-4085716807

   @laskoviymishka good feedback - I updated the PR with an option instead


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] fix(table): don't always set schema.name-mapping.default [iceberg-go]

Posted by "rockwotj (via GitHub)" <gi...@apache.org>.
rockwotj commented on PR #803:
URL: https://github.com/apache/iceberg-go/pull/803#issuecomment-4086444091

   > looks good, flag polarity is correct, and both methods are covered: mergeable as-is. That said, would really like to see at least one test: AddDataFiles with WithoutAutoNameMapping() against a table without an existing name mapping, asserting DefaultNameMappingKey is absent after commit — that's the exact UC failure path this PR is fixing.
   
   Fixed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] fix(table): don't always set schema.name-mapping.default [iceberg-go]

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #803:
URL: https://github.com/apache/iceberg-go/pull/803


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org