[GitHub] [incubator-superset] ktmud edited a comment on pull request #10158: build: upgrade Cypress and re-enable visualization tests

[GitBox <gi...@apache.org>]

ktmud edited a comment on pull request #10158:
URL: https://github.com/apache/incubator-superset/pull/10158#issuecomment-649703715


   > is file name change necessary? I prefer keep change history.
   
   Yes, it's necessary. It's hard to retain the history even if I split this to multiple commits with rename + change because the history will be lost during squash merge anyway.
   
   <strike>Plus most history for Cypress were already lost in #9098 . The oldest commit history one could get from a regular `git log` goes back to only February 2020.</strike> Histories are indeed available via `git log --follow` on individual files.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org