You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/07/06 00:23:09 UTC

[native-toolchain-CR] IMPALA-7252. Backport rate limiting of fadvise calls for glog 

Hello Tianyi Wang,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/10877

to review the following change.


Change subject: IMPALA-7252. Backport rate limiting of fadvise calls for glog
......................................................................

IMPALA-7252. Backport rate limiting of fadvise calls for glog

This backports a fix from glog[1] which limits the calling of advise to
at most once every 2MB written.

Tested that glog builds properly with this fix.

[1] https://github.com/google/glog/commit/dacd29679633c9b845708e7015bd2c79367a6ea2

Change-Id: I9f889343ffa458f86c3430b6a8cb2c0d5c14254a
---
M buildall.sh
A source/glog/glog-0.3.4-patches/0003-rate-limit-calls-to-posix_fadvise.patch
2 files changed, 110 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/77/10877/1
-- 
To view, visit http://gerrit.cloudera.org:8080/10877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f889343ffa458f86c3430b6a8cb2c0d5c14254a
Gerrit-Change-Number: 10877
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>

[native-toolchain-CR] IMPALA-7252. Backport rate limiting of fadvise calls for glog

Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10877 )

Change subject: IMPALA-7252. Backport rate limiting of fadvise calls for glog
......................................................................


Patch Set 1: Code-Review+2

Looks like a straightforward cherrypick. I'm building it and will merge if it builds on all supported linux distros.


-- 
To view, visit http://gerrit.cloudera.org:8080/10877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f889343ffa458f86c3430b6a8cb2c0d5c14254a
Gerrit-Change-Number: 10877
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Jul 2018 00:43:59 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-7252. Backport rate limiting of fadvise calls for glog

Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10877 )

Change subject: IMPALA-7252. Backport rate limiting of fadvise calls for glog
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/10877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f889343ffa458f86c3430b6a8cb2c0d5c14254a
Gerrit-Change-Number: 10877
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Jul 2018 18:27:49 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-7252. Backport rate limiting of fadvise calls for glog

Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10877 )

Change subject: IMPALA-7252. Backport rate limiting of fadvise calls for glog
......................................................................

IMPALA-7252. Backport rate limiting of fadvise calls for glog

This backports a fix from glog[1] which limits the calling of advise to
at most once every 2MB written.

Tested that glog builds properly with this fix.

[1] https://github.com/google/glog/commit/dacd29679633c9b845708e7015bd2c79367a6ea2

Change-Id: I9f889343ffa458f86c3430b6a8cb2c0d5c14254a
Reviewed-on: http://gerrit.cloudera.org:8080/10877
Reviewed-by: Tianyi Wang <tw...@cloudera.com>
Tested-by: Tianyi Wang <tw...@cloudera.com>
---
M buildall.sh
A source/glog/glog-0.3.4-patches/0003-rate-limit-calls-to-posix_fadvise.patch
2 files changed, 110 insertions(+), 1 deletion(-)

Approvals:
  Tianyi Wang: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/10877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9f889343ffa458f86c3430b6a8cb2c0d5c14254a
Gerrit-Change-Number: 10877
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>